pkg/tinycrypt: update commit hash after upstream rewrote history#10470
Merged
jcarrano merged 1 commit intoRIOT-OS:masterfrom Nov 26, 2018
Merged
Conversation
Upstream rewrote history in master which changed our reference commit from
intel/tinycrypt@3ea1a60
to
intel/tinycrypt@6a22712
Diff can be verified to be empty with:
intel/tinycrypt@6a22712...3ea1a60
cladmi
added
Area: pkg
jcarrano
approved these changes
Nov 26, 2018
Contributor
jcarrano
left a comment
jcarrano
left a comment
There was a problem hiding this comment.
One can also use this to check both commits are the same:
$ git clone --mirror [email protected]:01org/tinycrypt.git
$ cd tinycrypt.git
$ git branch the-missing-commit 3ea1a609e7aff9f2d8d13803e1076b7a8e551804
$ git diff the-missing-commit 6a22712bebbf2fc60d9fc6192dddefd5ad1933e3
Contributor
|
I know @haukepetersen was requested for review, but given that this is blocking everyone, I'm intervening the situation. |
Contributor
Author
|
Thanks for the review |
miri64
added
the
Type: bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
Upstream rewrote history in master which changed our reference commit from
to
Diff can be verified to be empty with:
Testing procedure
Murdock should build without failure to find
tinycryptcommit.And verify the commits content are the same.
Issues/PRs references
Main issue about upstream changing history is done in #10468