gnrc_ipv6: fix _fill_ipv6_hdr() for pure IPv6 packets#10422
Merged
miri64 merged 2 commits intoRIOT-OS:masterfrom Nov 17, 2018
Merged
gnrc_ipv6: fix _fill_ipv6_hdr() for pure IPv6 packets#10422miri64 merged 2 commits intoRIOT-OS:masterfrom
miri64 merged 2 commits intoRIOT-OS:masterfrom
Conversation
miri64
added
Type: bug
Member
|
The extended description of the first commit looks truncated to me |
Member
Author
|
Fixed. |
Member
|
Ack, please squash |
If a packet only contains IPv6 and IPv6 extension header snips (e.g. if the IPv6 packet has no payload or if an extension header was not pre-parsed)
Member
Author
|
Squashed |
miri64
force-pushed
the
gnrc_ipv6/bug/fill-until-end-case
branch
from
1adf7b5 to
d4f425b
Compare
Member
Author
|
Cool new feature with the force-push compare :o |
Member
Github stealing features from Gitlab again 😆 |
Member
Author
Didn't know GitLab has that :D |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
If an empty IPv6 packet or a packet only containing extension headers (or unparsed extension headers in case of routing and fragmentation headers) is sent the packet is currently dropped (or the node might even crash) due to this bug.
Testing procedure
Send an empty IPv6 packet or try the testing procedures I lined out in #10229 (comment)
Issues/PRs references
Discovered while testing #10229