make: add `BOARD_INSUFFICIENT_RAM` blacklisting by Kijewski · Pull Request #1039 · RIOT-OS/RIOT

Kijewski · 2014-04-22T10:37:30Z

Currently most blacklistings for examples and tests are done because the
board provides too little RAM or ROM. Besides of the actual linking all
the compiling should nevertheless work just fine.

This PR adds the variable BOARD_INSUFFICIENT_RAM to tell the
buildtest to compile the code for a board, but omit the linking step.

LudwigKnuepfer · 2014-04-22T14:36:21Z

Makefile

unreleated change

LudwigKnuepfer · 2014-04-22T14:43:23Z

Maybe I overlooked some more of the unrelated changes, but those we definitely want, so please split all of those - does not have to be a separate PR.
Then I'd like you to split the example changes if it's not too much trouble.

Kijewski · 2014-04-22T15:02:55Z

Made it 4 commits.

LudwigKnuepfer · 2014-04-22T15:07:29Z

ACK for 'unrelated changes :)' except for the commit message ;-)

Kijewski · 2014-04-22T15:08:50Z

It's not the unrelated changes that I want you ACK for, you know. 👅

LudwigKnuepfer · 2014-04-22T15:09:36Z

I had a little trouble parsing the emoticon .. I first thought it was a bottom with pointy ears =)

LudwigKnuepfer · 2014-04-22T15:10:16Z

And yes, I know.

Kijewski · 2014-04-22T15:14:02Z

Okay, okay, now with a proper commit message. :)

LudwigKnuepfer · 2014-04-22T15:18:29Z

Greatness =)

LudwigKnuepfer · 2014-04-22T15:22:46Z

Makefile.include

LudwigKnuepfer · 2014-04-22T15:28:30Z

ACK for 'Use BOARD_INSUFFICIENT_RAM in examples and tests'.

LudwigKnuepfer · 2014-04-22T15:43:43Z

ACK for 'make: parallelize creation of board and base code'.

LudwigKnuepfer · 2014-04-22T15:52:38Z

ACK for make: addBOARD_INSUFFICIENT_RAMblacklisting

==> ACK for the whole PR as it is now.

LudwigKnuepfer · 2014-04-22T16:22:16Z

Needs update if #1033 is merged first

Kijewski · 2014-04-22T16:26:58Z

Can I merge or does this PR need another pair of eyes?

LudwigKnuepfer · 2014-04-22T19:42:26Z

Looks like a core change to me.

Kijewski · 2014-04-23T03:41:50Z

I tend to agree.

Kijewski · 2014-04-25T06:23:31Z

Second ACK, anyone?

Kijewski · 2014-04-28T23:10:51Z

Please see #1073 which fixes the bug in ccn-lite-client.

OlegHahm · 2014-04-30T17:27:18Z

I don't understand the purpose of 71f515c .

LudwigKnuepfer · 2014-05-03T06:43:54Z

@OlegHahm Does this persist if you read the commit message?

Kijewski · 2014-05-03T14:01:04Z

Rebased on master. ~~71f515c~~ is now 1eb75f9.

Kijewski · 2014-05-03T14:03:32Z

@OlegHahm 1eb75f9 just exploits parallelization with make -j a little bit more, less sequential building, more parallel building. Without -j there should be no change at all.

Kijewski · 2014-05-06T15:31:35Z

@OlegHahm do you have open questions?

OlegHahm · 2014-05-14T12:54:49Z

Makefile.include

Please don't remove this output. It's very helpful to if you're building what you've intended to build.

OlegHahm · 2014-05-14T12:56:54Z

Apart from my comments and the fact that it needs to be rebases, this seems to be fine.

Kijewski · 2014-05-14T16:23:34Z

Rebased, @echo lines undeleted.
But "Building application hello-world for native w/ MCU native." will now occur at the end, not at the start. I cannot help that.

OlegHahm · 2014-05-15T09:45:59Z

But "Building application hello-world for native w/ MCU native." will now occur at the end, not at the start. I cannot help that.

Hm, that's quite unfortunate, since one only notices that one's building the wrong application or for the wrong board at the end. Is there no other target where to put it?

Apart, Travis is unhappy.

Kijewski · 2014-05-15T13:52:13Z

Darn, that's the calloc problem. Gonna blacklist.

Kijewski · 2014-05-15T14:55:04Z

~~Rebased~~ Depends on #1182.

LudwigKnuepfer · 2014-05-16T10:16:26Z

tests/test_thread_cooperation/Makefile

remove comments about insufficient ram

Kijewski · 2014-05-16T22:22:31Z

The "We can’t automatically merge this pull request." is because this commit is rebased on #1182, instead of master. I don't know why the commits of #1182 don't show up here.

miri64 · 2014-05-21T09:45:39Z

Is there a reason why it depends on the #1182? It does not seem related.

Kijewski · 2014-05-21T09:48:21Z

@authmillenon otherwise I cannot un-blacklist the MSP boards for the ccnl examples.

OlegHahm · 2014-05-23T09:12:36Z

Is https://github.com/Kijewski/RIOT/commit/cd04499e3f087922123aaa6fbaf5a6b6bb3ab335 the reason that the "Building..." info output isn't shown at the start any more? In this case I'd vote for removing that Commit from the PR and ACKing it.

Remove some outdated example code.

Currently most blacklistings for examples and tests are done because the board provides too little RAM or ROM. Besides of the actual linking all the compiling should nevertheless work just fine. This PR adds the variable `BOARD_INSUFFICIENT_RAM` to tell the `buildtest` to compile the code for a board, but omit the linking step.

Kijewski · 2014-05-23T12:32:08Z

Rebased. I unpicked https://github.com/Kijewski/RIOT/commit/cd04499e3f087922123aaa6fbaf5a6b6bb3ab335.

OlegHahm · 2014-05-24T12:49:03Z

ACK and go!

make: add `BOARD_INSUFFICIENT_RAM` blacklisting

Kijewski added this to the Release 2014.04 milestone Apr 22, 2014

Kijewski assigned mehlis Apr 22, 2014

Kijewski added enhancement labels Apr 22, 2014

Kijewski assigned LudwigKnuepfer and unassigned mehlis Apr 22, 2014

LudwigKnuepfer reviewed Apr 22, 2014
View reviewed changes

Makefile Outdated

Copy link
Copy Markdown

Member

LudwigKnuepfer Apr 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unreleated change

LudwigKnuepfer reviewed Apr 22, 2014
View reviewed changes

Makefile.include Outdated

Copy link
Copy Markdown

Member

LudwigKnuepfer Apr 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these ::

LudwigKnuepfer mentioned this pull request Apr 22, 2014

make: comprehensive list of the boards' filesizes #1033

Merged

Kijewski mentioned this pull request Apr 24, 2014

Tests that fail to build #1049

Closed

Kijewski added the NEEDS SQUASHING label Apr 26, 2014

LudwigKnuepfer assigned OlegHahm Apr 27, 2014

Kijewski removed the NEEDS SQUASHING label Apr 29, 2014

Kijewski mentioned this pull request May 3, 2014

make: Make make more flexible #1098

Merged

Kijewski added the make label May 5, 2014

OlegHahm reviewed May 14, 2014
View reviewed changes

LudwigKnuepfer reviewed May 16, 2014
View reviewed changes

tests/test_thread_cooperation/Makefile Outdated

Copy link
Copy Markdown

Member

LudwigKnuepfer May 16, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments about insufficient ram

Kijewski added 3 commits May 23, 2014 14:28

make: remove clutter

27ae094

Remove some outdated example code.

Use BOARD_INSUFFICIENT_RAM in examples and tests

4977875

OlegHahm added a commit that referenced this pull request May 24, 2014

Merge pull request #1039 from Kijewski/buildtest-insufficient-ram

f2ee98c

make: add `BOARD_INSUFFICIENT_RAM` blacklisting

OlegHahm merged commit f2ee98c into RIOT-OS:master May 24, 2014

Kijewski deleted the buildtest-insufficient-ram branch May 24, 2014 14:24

Conversation

Kijewski commented Apr 22, 2014

Uh oh!

LudwigKnuepfer Apr 22, 2014

Choose a reason for hiding this comment

Uh oh!

LudwigKnuepfer commented Apr 22, 2014

Uh oh!

Kijewski commented Apr 22, 2014

Uh oh!

LudwigKnuepfer commented Apr 22, 2014

Uh oh!

Kijewski commented Apr 22, 2014

Uh oh!

LudwigKnuepfer commented Apr 22, 2014

Uh oh!

LudwigKnuepfer commented Apr 22, 2014

Uh oh!

Kijewski commented Apr 22, 2014

Uh oh!

LudwigKnuepfer commented Apr 22, 2014

Uh oh!

LudwigKnuepfer Apr 22, 2014

Choose a reason for hiding this comment

Uh oh!

LudwigKnuepfer commented Apr 22, 2014

Uh oh!

LudwigKnuepfer commented Apr 22, 2014

Uh oh!

LudwigKnuepfer commented Apr 22, 2014

Uh oh!

LudwigKnuepfer commented Apr 22, 2014

Uh oh!

Kijewski commented Apr 22, 2014

Uh oh!

LudwigKnuepfer commented Apr 22, 2014

Uh oh!

Kijewski commented Apr 23, 2014

Uh oh!

Kijewski commented Apr 25, 2014

Uh oh!

Kijewski commented Apr 28, 2014

Uh oh!

OlegHahm commented Apr 30, 2014

Uh oh!

LudwigKnuepfer commented May 3, 2014

Uh oh!

Kijewski commented May 3, 2014

Uh oh!

Kijewski commented May 3, 2014

Uh oh!

Kijewski commented May 6, 2014

Uh oh!

OlegHahm May 14, 2014

Choose a reason for hiding this comment

Uh oh!

OlegHahm commented May 14, 2014

Uh oh!

Kijewski commented May 14, 2014

Uh oh!

OlegHahm commented May 15, 2014

Uh oh!

Kijewski commented May 15, 2014

Uh oh!

Kijewski commented May 15, 2014

Uh oh!

LudwigKnuepfer May 16, 2014

Choose a reason for hiding this comment

Uh oh!

Kijewski commented May 16, 2014

Uh oh!

miri64 commented May 21, 2014

Uh oh!

Kijewski commented May 21, 2014

Uh oh!

OlegHahm commented May 23, 2014

Uh oh!

Kijewski commented May 23, 2014

Uh oh!

OlegHahm commented May 24, 2014