Skip to content

gnrc_pktdump: add GNRC_NETTYPE_IPV6_EXT output#10383

Merged
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:gnrc_pktdump/enh/add-ipv6-ext
Dec 18, 2018
Merged

gnrc_pktdump: add GNRC_NETTYPE_IPV6_EXT output#10383
miri64 merged 1 commit intoRIOT-OS:masterfrom
miri64:gnrc_pktdump/enh/add-ipv6-ext

Conversation

@miri64
Copy link
Copy Markdown
Member

@miri64 miri64 commented Nov 13, 2018

Contribution description

Just noticed in #10382 that GNRC_NETTYPE_IPV6_EXT snips are marked as NETTYPE_UNKNOWN in gnrc_pktdump (but the PRs are independent).

Testing procedure

Compile #10382 with and without this PR. If you set echo in the testrunner to True you will see that the marked extension headers are shown as NETTYPE_IPV6_EXT instead of NETTYPE_UNKNOWN (remark: extension headers shown with NETTYPE_UNDEF are unmarked and thus shown correctly in that test).

Issues/PRs references

None (but #10382 required for testing)

@miri64 miri64 added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 13, 2018
@miri64 miri64 mentioned this pull request Nov 17, 2018
Merged
@miri64 miri64 added the Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties label Dec 14, 2018
@miri64 miri64 force-pushed the gnrc_pktdump/enh/add-ipv6-ext branch from 2b45051 to e06cdcd Compare December 14, 2018 00:38
@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Dec 14, 2018

Rebased to current master. This is a really low hanging fruit ;-). Anyone wants to review?

@miri64
Copy link
Copy Markdown
Member Author

miri64 commented Dec 14, 2018

@cladmi @jia200x @kb2ma?

cgundogan
cgundogan approved these changes Dec 18, 2018
View reviewed changes
Copy link
Copy Markdown
Member

@cgundogan cgundogan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@cgundogan cgundogan added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines labels Dec 18, 2018
@miri64 miri64 removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 18, 2018
@cgundogan cgundogan removed the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 18, 2018
@miri64 miri64 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Dec 18, 2018
@miri64 miri64 merged commit 5e03f58 into RIOT-OS:master Dec 18, 2018
@miri64 miri64 deleted the gnrc_pktdump/enh/add-ipv6-ext branch December 18, 2018 19:52
@aabadie aabadie added this to the Release 2019.01 milestone Dec 19, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cgundogan cgundogan cgundogan approved these changes

Assignees

No one assigned

Labels

Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Community: Hack'n'ACK candidate This PR is a candidate for review and discussion during one of RIOT's monthly Hack'n'ACK parties Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation

Projects

None yet

Milestone

Release 2019.01

Development

Successfully merging this pull request may close these issues.

3 participants

@miri64 @cgundogan @aabadie