Skip to content

drivers/hd44780: fix compilation errors#10145

Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
gschorcht:drivers_hd44780_fix
Oct 12, 2018
Merged

drivers/hd44780: fix compilation errors#10145
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
gschorcht:drivers_hd44780_fix

Conversation

@gschorcht
Copy link
Copy Markdown
Contributor

@gschorcht gschorcht commented Oct 11, 2018

Contribution description

This PR fixes a compilation problem because of conflicting types I had on platform ESP32:

drivers/hd44780/hd44780.c:71:13: error: conflicting types for '_send'
 static void _send(const hd44780_t *dev, uint8_t value, hd44780_state_t state)
             ^
drivers/hd44780/hd44780.c:35:13: note: previous declaration of '_send' was here
 static void _send(const hd44780_t *dev, uint8_t value, uint8_t mode);

Testing procedure

make BOARD=arduino-uno -C tests/driver_hd44780/

@gschorcht gschorcht mentioned this pull request Oct 11, 2018
Merged
@MrKevinWeiss MrKevinWeiss added Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 11, 2018
MrKevinWeiss
MrKevinWeiss approved these changes Oct 11, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, it seems silly the compiler doesn't catch it. ACK

@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Oct 11, 2018

It seems that murdock fails for a reason that is not related to this PR 😟

--- build output of app tests/cpp11_condition_variable for board nrf52dk:llvm
Building application "tests_cpp11_condition_variable" for "nrf52dk" with MCU "nrf52".

/tmp/dwq.0.6798942550071656/a0851f1d3128c9babdf5204c7b5b98a8/tests/cpp11_condition_variable/main.cpp:21:10: fatal error: 'string' file not found
#include 
         ^
1 error generated.

@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Oct 11, 2018

@miri64 Any idea, is this to do with the llvm?

@MrKevinWeiss MrKevinWeiss added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 12, 2018
@MrKevinWeiss
Copy link
Copy Markdown
Contributor

MrKevinWeiss commented Oct 12, 2018

All good now!

@MrKevinWeiss MrKevinWeiss merged commit 33aa604 into RIOT-OS:master Oct 12, 2018
@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Oct 12, 2018

@MrKevinWeiss Thanks

@gschorcht
Copy link
Copy Markdown
Contributor Author

gschorcht commented Oct 12, 2018

@MrKevinWeiss You should now be able to compiletests/hd44780 with ESP32 boards.

@gschorcht gschorcht deleted the drivers_hd44780_fix branch October 12, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

Assignees

No one assigned

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gschorcht @MrKevinWeiss