board/mips-malta: include the cpu features instead of common cpu#10064
Merged
smlng merged 1 commit intoRIOT-OS:masterfrom Oct 1, 2018
Merged
board/mips-malta: include the cpu features instead of common cpu#10064smlng merged 1 commit intoRIOT-OS:masterfrom
smlng merged 1 commit intoRIOT-OS:masterfrom
Conversation
This change was missed when the cpu 'mips32r2_generic' was separated from 'mips32r2_common'. The target file already includes 'mips32r2_common'.
cladmi
added
Impact: minor
22 tasks
smlng
approved these changes
Sep 28, 2018
Member
smlng
left a comment
smlng
left a comment
There was a problem hiding this comment.
tested ACK, output of make info-build is also (mostly) equal, this PR only adds the Makefile.features from the generic folder
Contributor
Author
|
Thanks for reviewing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
board/mips-malta: include the cpu features instead of common cpu
This change was missed when the cpu 'mips32r2_generic' was separated
from 'mips32r2_common'. The target file already includes 'mips32r2_common'.
Testing procedure
The
FEATURES_PROVIDEDdo not change between master and this PR formips-malta:Issues/PRs references
Inconsistency found while working on #9913