cpu/esp8266: remove duplicate 'CPU' variable#10061
Merged
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom Sep 28, 2018
Merged
cpu/esp8266: remove duplicate 'CPU' variable#10061MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
MrKevinWeiss merged 1 commit intoRIOT-OS:masterfrom
Conversation
cladmi
added
Impact: minor
Contributor
Author
|
@gschorcht a minor change in your cpu |
Contributor
|
@cladmi thanks |
22 tasks
MrKevinWeiss
approved these changes
Sep 28, 2018
Contributor
MrKevinWeiss
left a comment
MrKevinWeiss
left a comment
There was a problem hiding this comment.
ACK! Tested with make --no-print-directory -C examples/hello-world/ info-debug-variable-CPU BOARD=esp8266-esp-12x and with BOARD=esp8266-esp-12x make all -C tests/leds/ both behave as expected.
Contributor
Author
|
Thanks for reviewing Mr "Bear Puncher" :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contribution description
CPU is already defined as
cpu/$(CPU)points tocpu/esp8266.This is a minor change I found while looking which files defined 'CPU'.
Testing procedure
The CPU value is unchanged
Building in CI should still work.
Issues/PRs references
Found while working on #9913