Skip to content

cpu/nrf5x/gpio: use periph_gpio_irq feature#10005

Merged
haukepetersen merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_gpioirq_nrf
Sep 26, 2018
Merged

cpu/nrf5x/gpio: use periph_gpio_irq feature#10005
haukepetersen merged 1 commit intoRIOT-OS:masterfrom
haukepetersen:fix_gpioirq_nrf

Conversation

@haukepetersen
Copy link
Copy Markdown
Contributor

See #9992

@ghost
Copy link
Copy Markdown

ghost commented Sep 26, 2018

Tested sucessfully with nrf52840dk, nrf52dk and calliope-mini (nrf51 CPU).

Copy link
Copy Markdown
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Proxy-ACK. Sat next to @SemjonKerner when he did it.

@miri64 miri64 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: cpu Area: CPU/MCU ports Platform: ARM Platform: This PR/issue effects ARM-based platforms labels Sep 26, 2018
@haukepetersen haukepetersen added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: drivers Area: Device drivers and removed Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: cpu Area: CPU/MCU ports labels Sep 26, 2018
@haukepetersen
Copy link
Copy Markdown
Contributor Author

all green -> go

@haukepetersen haukepetersen merged commit 272ae30 into RIOT-OS:master Sep 26, 2018
@haukepetersen haukepetersen deleted the fix_gpioirq_nrf branch September 26, 2018 15:59
@jia200x jia200x added this to the Release 2018.10 milestone Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants