Skip to content

RFC: Set PSEUDOMODULES in packages Makefile.include #8984

@cladmi

Description

@cladmi

Description

I was the one suggesting @bergzand to set PSEUDOMODULES in his libcose package Makefile.include while developing so he would not need to modify the other RIOT files.

# Declare pseudomodules here to be selfcontained
PSEUDOMODULES += libcose_crypt_%

I also thought it could be the occasion to ask if it is something we may want to do for packages as they already provide Makefile.include and Makefile.dep

As it has been merged, it is even more important to ask the question.

I plan to do a PR to also allow having a Makefile.include and Makefile.dep for EXTERNAL_MODULE_DIRS. So these directories would need to do this also.

Question

For packages, do we want to set the PSEUDOMODULES variables in the package Makefile.include instead of the centralized file ?

I would like to have your feedback and arguments if you are against.

Next steps

Depending on the result, either, change the libcose package, or add documentation saying that it's possible and wanted, a comment at the bottom of pseudomodules.inc.mk and update packages accordingly.

Metadata

Metadata

Labels

Area: build systemArea: Build systemArea: pkgArea: External package portsDiscussion: RFCThe issue/PR is used as a discussion starting point about the item of the issue/PR

Type

No type

Projects

No projects

Relationships

None yet

Development

No branches or pull requests

Issue actions