Skip to content

Tinycryt upstream rewrote history in master branch #10468

@cladmi

Description

@cladmi

Description

Murdock recently fails to build packages related to tinycrypt as the reference commit was removed from the upstream master branch:

https://ci.riot-os.org/RIOT-OS/RIOT/9819/ae4cecd14c36f7bf68a5357727e5874822bebe60/output/compile/tests/pkg_tinycrypt/native:gnu.txt

The commit was this one intel/tinycrypt@3ea1a60 and as you can see, it does not reference any branch.

The new commit is this one: intel/tinycrypt@6a22712

Thanks to the new github feature to show forced push we can easily see here that the master branch was force-pushed:

intel/tinycrypt#35

Also attached as an image.

2018-11-26-153833_5120x1440_scrot

Original PR adding this commit:

intel/tinycrypt#29

Handling of this

Both commits can be compared and contain the same content, so could be replaced one by another.
I will do a PR to update to the new reference as the content stayed the same.

However, what is the state of keeping a package in RIOT, even more a cryptographic library, where upstream rewrites history in master ? 11month after being merged…

Versions

https://github.com/RIOT-OS/RIOT/blob/ce8815f4d1af13ef21528c8140a226b3b24143d0/pkg/tinycrypt/Makefile

Metadata

Metadata

Assignees

No one assigned

    Labels

    Area: pkgArea: External package portsArea: securityArea: Security-related libraries and subsystemsType: bugThe issue reports a bug / The PR fixes a bug (including spelling errors)

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions