-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Make warns to expect errors when disabling optional modules #10047
Copy link
Copy link
Closed
Labels
Area: build systemArea: Build systemArea: Build systemState: staleState: The issue / PR has no activity for >185 daysState: The issue / PR has no activity for >185 daysType: bugThe issue reports a bug / The PR fixes a bug (including spelling errors)The issue reports a bug / The PR fixes a bug (including spelling errors)
Description
When testing #10005 I got a warning from Make to EXPECT ERRORS! when compiling with DISABLE_MODULE=periph_gpio_irq.
This warning is needless since the feature periph_gpio_irq is optional and thus excluding it should not throw any errors. Even more, if it throws errors then there is a bug that should neither be expected nor in the code at all.
Meaning if a feature added with FEATURES_OPTIONAL is excluded again with DISABLE_MODULE, this warning should not be printed.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
Area: build systemArea: Build systemArea: Build systemState: staleState: The issue / PR has no activity for >185 daysState: The issue / PR has no activity for >185 daysType: bugThe issue reports a bug / The PR fixes a bug (including spelling errors)The issue reports a bug / The PR fixes a bug (including spelling errors)