pkg/lwext4: don't consider fs mounted if recover fails

benpicco · benpicco · commit e2cee4255dfb · 2023-11-09T20:15:53.000+01:00
diff --git a/pkg/lwext4/fs/lwext4_fs.c b/pkg/lwext4/fs/lwext4_fs.c
@@ -214,7 +214,6 @@ static int _mount(vfs_mount_t *mountp)
     }
 
     mp->os_locks = &_lwext4_os_lock;
-    mp->mounted = true;
 
     res = ext4_recover(fs->mp.name);
     if (res != EOK && res != ENOTSUP) {
@@ -228,6 +227,7 @@ static int _mount(vfs_mount_t *mountp)
         return -res;
     }
 
+    mp->mounted = true;
     ext4_cache_write_back(fs->mp.name, 1);
 
     return -res;

Original file line number	Diff line number	Diff line change
`@@ -214,7 +214,6 @@ static int _mount(vfs_mount_t *mountp)`
`214`	`214`	`}`
`215`	`215`
`216`	`216`	`mp->os_locks = &_lwext4_os_lock;`
`217`		`- mp->mounted = true;`
`218`	`217`
`219`	`218`	`res = ext4_recover(fs->mp.name);`
`220`	`219`	`if (res != EOK && res != ENOTSUP) {`
`@@ -228,6 +227,7 @@ static int _mount(vfs_mount_t *mountp)`
`228`	`227`	`return -res;`
`229`	`228`	`}`
`230`	`229`
	`230`	`+ mp->mounted = true;`
`231`	`231`	`ext4_cache_write_back(fs->mp.name, 1);`
`232`	`232`
`233`	`233`	`return -res;`