tests/heap_cmd: fix -Wuse-after-free

maribu · maribu · commit c95e8553ef47 · 2022-09-16T13:15:46.000+02:00
Strictly speaking, this is not actually a use after free, as only the
address of the freed memory chunk is printed. The freed memory is not
accesses. However, this is more idiomatic this way.
diff --git a/tests/heap_cmd/main.c b/tests/heap_cmd/main.c
@@ -43,8 +43,8 @@ static int free_cmd(int argc, char **argv)
 
     unsigned int p = strtoul(argv[1], NULL, 16);
     void *ptr = (void *)p;
+    printf("freeing %p\n", ptr);
     free(ptr);
-    printf("freed %p\n", ptr);
     return 0;
 }
 

Original file line number	Diff line number	Diff line change
`@@ -43,8 +43,8 @@ static int free_cmd(int argc, char **argv)`
`43`	`43`
`44`	`44`	`unsigned int p = strtoul(argv[1], NULL, 16);`
`45`	`45`	`void ptr = (void )p;`
	`46`	`+ printf("freeing %p\n", ptr);`
`46`	`47`	`free(ptr);`
`47`		`- printf("freed %p\n", ptr);`
`48`	`48`	`return 0;`
`49`	`49`	`}`
`50`	`50`