cpu/sam0_common/periph_gpio_ll: fix gpio_query_conf()

maribu · maribu · commit 779aaedcc5f2 · 2024-11-19T10:05:41.000+01:00
For the other MCUs, we take the input register state instead of the output register state when the pin is configured as input. Let's do the same here, as this is a lot more useful and intuitive. (cherry picked from commit 0222b8c)
diff --git a/cpu/sam0_common/periph/gpio_ll.c b/cpu/sam0_common/periph/gpio_ll.c
@@ -204,7 +204,12 @@ gpio_conf_t gpio_ll_query_conf(gpio_port_t port, uint8_t pin)
         }
     }
 
-    result.initial_value = iobus->OUT.reg & pin_mask;
+    if (result.state == GPIO_INPUT) {
+        result.initial_value = (gpio_ll_read(port) >> pin) & 1UL;
+    }
+    else {
+        result.initial_value = (gpio_ll_read_output(port) >> pin) & 1UL;
+    }
 
     return result;
 }

Original file line number	Diff line number	Diff line change
`@@ -204,7 +204,12 @@ gpio_conf_t gpio_ll_query_conf(gpio_port_t port, uint8_t pin)`
`204`	`204`	`}`
`205`	`205`	`}`
`206`	`206`
`207`		`- result.initial_value = iobus->OUT.reg & pin_mask;`
	`207`	`+ if (result.state == GPIO_INPUT) {`
	`208`	`+ result.initial_value = (gpio_ll_read(port) >> pin) & 1UL;`
	`209`	`+ }`
	`210`	`+ else {`
	`211`	`+ result.initial_value = (gpio_ll_read_output(port) >> pin) & 1UL;`
	`212`	`+ }`
`208`	`213`
`209`	`214`	`return result;`
`210`	`215`	`}`