hashes/sha224: Remove static variables from sha224

bergzand · bergzand · commit 434e5647d04f · 2024-01-16T16:00:44.000+01:00
diff --git a/sys/hashes/sha224.c b/sys/hashes/sha224.c
@@ -19,6 +19,7 @@
  */
 
 #include <string.h>
+#include <assert.h>
 
 #include "hashes/sha224.h"
 #include "hashes/sha2xx_common.h"
@@ -40,18 +41,12 @@ void sha224_init(sha224_context_t *ctx)
     ctx->state[7] = 0xBEFA4FA4;
 }
 
-void *sha224(const void *data, size_t len, void *digest)
+void sha224(const void *data, size_t len, void *digest)
 {
     sha224_context_t c;
-    static unsigned char m[SHA224_DIGEST_LENGTH];
-
-    if (digest == NULL) {
-        digest = m;
-    }
+    assert(digest);
 
     sha224_init(&c);
     sha224_update(&c, data, len);
     sha224_final(&c, digest);
-
-    return digest;
 }
diff --git a/sys/include/hashes/sha224.h b/sys/include/hashes/sha224.h
@@ -110,11 +110,10 @@ static inline void sha224_final(sha224_context_t *ctx, void *digest)
  *
  * @param[in] data   pointer to the buffer to generate hash from
  * @param[in] len    length of the buffer
- * @param[out] digest optional pointer to an array for the result, length must
+ * @param[out] digest Pointer to an array for the result, length must
  *                    be SHA224_DIGEST_LENGTH
- *                    if digest == NULL, one static buffer is used
  */
-void *sha224(const void *data, size_t len, void *digest);
+void sha224(const void *data, size_t len, void *digest);
 
 #ifdef __cplusplus
 }

Original file line number	Diff line number	Diff line change
`@@ -110,11 +110,10 @@ static inline void sha224_final(sha224_context_t ctx, void digest)`
`110`	`110`	`*`
`111`	`111`	`* @param[in] data pointer to the buffer to generate hash from`
`112`	`112`	`* @param[in] len length of the buffer`
`113`		`- * @param[out] digest optional pointer to an array for the result, length must`
	`113`	`+ * @param[out] digest Pointer to an array for the result, length must`
`114`	`114`	`* be SHA224_DIGEST_LENGTH`
`115`		`- * if digest == NULL, one static buffer is used`
`116`	`115`	`*/`
`117`		`-void sha224(const void data, size_t len, void *digest);`
	`116`	`+void sha224(const void data, size_t len, void digest);`
`118`	`117`
`119`	`118`	`#ifdef __cplusplus`
`120`	`119`	`}`