Change code block detection to include parentheses#1269
Merged
andycraig merged 1 commit intoREditorSupport:masterfrom Dec 4, 2022
Merged
Change code block detection to include parentheses#1269andycraig merged 1 commit intoREditorSupport:masterfrom
andycraig merged 1 commit intoREditorSupport:masterfrom
Conversation
Collaborator
Author
|
@renkun-ken Thanks for the review! I'll merge now. |
Collaborator
Author
|
@renkun-ken CI test stage failed but it's not the error I would have expected if the unit tests themselves had failed. (I ran the unit tests before making the PR.) I'm a bit unsure what I need to do for this error. Any ideas? |
Member
|
It occurs occasionally. It usually resolves on its own when re-run. |
Collaborator
Author
|
@renkun-ken I see you re-ran it and it passed. Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #437
Closes #1104
Currently, when cursor is on line 2 or 3 of the below code and
R: Run Selection/Lineis used, only lines 2-3 are sent to the console and a syntax error occurs. This PR causes all four lines to be sent to the console, fixing the error.This also changes existing behaviour in cases like the below code. Currently, when the cursor is on line 2, only
x = 1is sent to the console. This PR causes all three lines to be sent to the console instead.This new behaviour is more consistent with RStudio. This can be seen in two of the changed unit tests, which directly compare RStudio and vscode-R behaviour.