Skip to content

fix: Address clippy error regarding zombie child process#1053

Merged
GeckoEidechse merged 1 commit into
mainfrom
fix/clippy-error-child-process
Dec 9, 2024
Merged

fix: Address clippy error regarding zombie child process#1053
GeckoEidechse merged 1 commit into
mainfrom
fix/clippy-error-child-process

Conversation

@GeckoEidechse

Copy link
Copy Markdown
Member

https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes

warning: spawned process is never `wait()`ed on
   --> src/northstar/mod.rs:217:23
    |
217 |           let _output = std::process::Command::new("C:\\Windows\\System32\\cmd.exe")
    |  _______________________^
218 | |             .args(["/C", "start", "", &ns_exe_path, &ns_profile_arg])
219 | |             .spawn()
220 | |             .expect("failed to execute process");
    | |________________________________________________^
    |
    = note: consider calling `.wait()`
    = note: not doing so might leave behind zombie processes
    = note: see https://doc.rust-lang.org/stable/std/process/struct.Child.html#warning
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zombie_processes
    = note: `#[warn(clippy::zombie_processes)]` on by default

@GeckoEidechse GeckoEidechse mentioned this pull request Dec 9, 2024
4 tasks

@GeckoEidechse GeckoEidechse left a comment

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Alystrasz confirmed working in quick testing.

@GeckoEidechse GeckoEidechse merged commit deb20be into main Dec 9, 2024
@GeckoEidechse GeckoEidechse deleted the fix/clippy-error-child-process branch December 9, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant