Add ldd --version check#10
Conversation
GeckoEidechse
left a comment
GeckoEidechse
left a comment
There was a problem hiding this comment.
Thanks for the PR <3
Noticed a few things and annotated them accordingly. Need to test compile on Windows still but if it does (and the annotated things are resolved) should be good to merge ^^
I assume it worked on your machine?
Alystrasz
left a comment
Alystrasz
left a comment
There was a problem hiding this comment.
Lacks some comments and features some typos
|
Ok I think all review requests have been satisfied. It built and ran on both linux and windows on my machine, since it's still in the dev view it's not implemented. Next I'll prolly do nsproton and work this all into that. |
Alystrasz
left a comment
Alystrasz
left a comment
There was a problem hiding this comment.
Typos, typos everywhere
GeckoEidechse
left a comment
GeckoEidechse
left a comment
There was a problem hiding this comment.
Doesn't break Windows and I assume Linux was tested, so fine to merge by me ^^
feat: Show own version number in settings view (#11)
GeckoEidechse
left a comment
GeckoEidechse
left a comment
There was a problem hiding this comment.
So it works on Linux now without crash :D
But Windows fails to compile now atm ._.
| serde_json = "1.0" | ||
| serde = { version = "1.0", features = ["derive"] } | ||
| tauri = { version = "1.1.1", features = ["api-all", "updater"] } | ||
| tauri = { version = "1.1.1", features = ["api-all"] } |
There was a problem hiding this comment.
Oh keep forgetting this
| [[package]] | ||
| name = "minisign-verify" | ||
| version = "0.2.1" | ||
| source = "registry+https://github.com/rust-lang/crates.io-index" | ||
| checksum = "933dca44d65cdd53b355d0b73d380a2ff5da71f87f036053188bf1eab6a19881" | ||
|
|
There was a problem hiding this comment.
btw, why is Cargo.lock not in the gitignore?
There was a problem hiding this comment.
It allows developers to have exact same versions of dependencies
There was a problem hiding this comment.
It's the same as NPM and package-lock.json. Locks dependency to certain version for reproducible builds.
Various fixes
| fn linux_checks() -> bool { | ||
| if get_host_os() == "windows" { | ||
| false | ||
| } else { | ||
| linux_checks_librs() | ||
| } | ||
| } |
There was a problem hiding this comment.
Should probably be changed to returning a Result<T,E> type in the future but fine as is for now for me ^^
|
Tested working on Linux, will merge if CI passes. |
3 participants
hahhah finally the button works
Added a function in
linux.rsto checkldd --version>= 2.33, but rn its inside of a generallinux_checksfunction. Returns a bool so that anything about checking linux compatibility in the future can just be 1 button.