test(qwik-e2e): assert non-asserting e2e checks

voidmatcha · voidmatcha · commit b41c1e8634c8 · 2026-06-27T00:30:08.000+09:00
Replace an always-true toBeDefined on a getAttribute result and a bare isVisible call with web-first assertions so the checks can actually fail. Re-targets #8727 onto build/v2 at wmertens' request.
diff --git a/e2e/qwik-e2e/tests/sync-qrl.e2e.ts b/e2e/qwik-e2e/tests/sync-qrl.e2e.ts
@@ -24,6 +24,6 @@ test.describe('resuming', () => {
     // clicking checkbox does not toggles the checked state, because default is prevented.
     await input.click();
     await expect(input).toBeChecked();
-    await expect(await input.getAttribute('prevented')).toBeDefined();
+    await expect(input).toHaveAttribute('prevented', 'true');
   });
 });
diff --git a/e2e/qwik-e2e/tests/use-id.e2e.ts b/e2e/qwik-e2e/tests/use-id.e2e.ts
@@ -15,7 +15,7 @@ test.describe('use-id', () => {
 
   test('Creates unique ids and ensure no collisions', async ({ page }) => {
     const totalIdsLocator = page.locator('#totalIds');
-    await totalIdsLocator.isVisible();
+    await expect(totalIdsLocator).toBeVisible();
     const totalIdsText = await totalIdsLocator.textContent();
     const totalIds = parseInt(totalIdsText || '-1');
     await expect(totalIds).toBeGreaterThan(0); // MAKE SURE WE HAVE SOME IDS
