@qwen-code /review

Summary:
- Fixed the update command auto-update-disabled flow and TS2367 narrowing issue.
- Made non-interactive/ACP /update return actionable manual update commands.
- Renamed updateCommand.ts to update-command.ts.
- Fixed standalone update failure exit code handling.
- Added focused tests for CLI update, slash update, tar link validation, wrapper quoting, legacy PATH marker handling, and bash rc selection.
- Hardened tar link target validation for symlinks and hardlinks.
- Made wrapper creation atomic and fixed shell quoting for paths containing single quotes.
- Aligned bash rc selection with the install script and preserved legacy PATH marker compatibility.
- Removed unnecessary ink aliases from esbuild.config.js.
- Restored final newlines in locale files.

Verification:
- npx vitest run packages/cli/src/utils/standalone-update.test.ts packages/cli/src/commands/update.test.ts packages/cli/src/ui/commands/update-command.test.ts --pool=forks --poolOptions.forks.singleFork=true passed: 33 tests.
- npx eslint esbuild.config.js packages/cli/src/commands/update.ts packages/cli/src/commands/update.test.ts packages/cli/src/ui/commands/update-command.ts packages/cli/src/ui/commands/update-command.test.ts packages/cli/src/utils/standalone-update.ts packages/cli/src/utils/standalone-update.test.ts packages/cli/src/services/BuiltinCommandLoader.ts --ext .js,.ts passed.

Please continue reviewing when you have a chance.

Addressed the latest review follow-ups in 10d3f36.

Summary:

• Fixed the update command test handler args with a typed ArgumentsCamelCase value instead of {}.
• Added /update fallback guidance when no package-manager update command is available.
• Extracted shared update-command version replacement into resolveUpdateCommand.
• Added standalone update success and deferred-path tests.
• Removed the now-unused Auto-update is disabled... i18n key from all locale files.
• Limited the Unix post-extraction path validation sweep to symlinks while keeping the full scan for Windows extraction.

Verification:

• npx vitest run packages/cli/src/commands/update.test.ts packages/cli/src/ui/commands/update-command.test.ts packages/cli/src/utils/standalone-update.test.ts --pool=forks --poolOptions.forks.singleFork=true passed: 37 tests.
• npx eslint packages/cli/src/commands/update.ts packages/cli/src/commands/update.test.ts packages/cli/src/ui/commands/update-command.ts packages/cli/src/ui/commands/update-command.test.ts packages/cli/src/utils/standalone-update.ts packages/cli/src/utils/installationInfo.ts --ext .ts passed.

Note: npm run typecheck --workspace=packages/cli --if-present still fails locally because packages/core/dist/src/utils/toml-to-markdown-converter*.d.ts has not been built in this checkout, which is the same local build artifact issue seen earlier.

Please continue reviewing when you have a chance.

Following up on the enableAutoUpdate note above — I think it's actually the crux of whether these two commands earn their place, so worth spelling out.

Today the startup path already auto-updates everyone who hasn't disabled it: gemini.tsx runs checkForUpdates() → handleAutoUpdate() whenever enableAutoUpdate !== false, and handleAutoUpdate doesn't just notify — for standalone it self-installs (applied next run), and for npm/yarn/pnpm with a writable prefix it actually spawns the install command. So for the default case (auto-update on), qwen update / /update mostly trigger now what the next launch would do anyway — and for standalone it still only applies on restart.

That leaves two cases where an explicit command is genuinely non-redundant:

1. Users who set enableAutoUpdate: false and want to update on their own schedule.
2. Headless / scripted invocation (qwen update in CI or cron), which the TUI startup path can't serve.

Both are exactly what the current gating turns off — both commands early-out on enableAutoUpdate !== false, so a standalone user who disabled auto-update gets "Unable to auto-update… please reinstall" instead of an update. As written, the command is closest to a duplicate of the startup path for the people who need it least.

The direction — a first-class update verb — is the right instinct; most standalone CLIs have one. To make it pull its weight, I'd suggest enableAutoUpdate gate only the background/startup behavior, and an explicit qwen update / /update run regardless (the user is asking to update now). Worth settling that contract before merge.

Related, smaller: there are now three paths that check-and-update — startup handleAutoUpdate, /update, and qwen update — and their success messages already differ ("used on your next run" vs "Please restart Qwen Code" vs "applied after you exit this session"). Funnelling all three through one core would stop them drifting.

Not blocking on its own — the build error above is the real merge blocker — but this is the design question I'd want answered.

Addressed the latest follow-ups in af5d733.

Summary:

• Updated the tar filter helper typing to accept the actual tar filter entry shapes (Stats | ReadEntry | { type?: string; linkpath?: unknown }) and safely inspect type/linkpath via property guards.
• Kept hardlinks rejected outright while preserving symlink target validation.
• Added a regression test covering fs.statSync(...) entries passed through the tar filter typing path.
• Raised the SDK daemon browser bundle guard from 125KB to 126KB for the current output.

Verification:

• npx vitest run packages/cli/src/utils/standalone-update.test.ts packages/cli/src/commands/update.test.ts packages/cli/src/ui/commands/update-command.test.ts --pool=forks --poolOptions.forks.singleFork=true passed: 42 tests.
• npx eslint packages/cli/src/utils/standalone-update.ts packages/cli/src/utils/standalone-update.test.ts packages/cli/src/commands/update.ts packages/cli/src/commands/update.test.ts packages/cli/src/ui/commands/update-command.ts packages/cli/src/ui/commands/update-command.test.ts packages/cli/src/utils/installationInfo.ts packages/sdk-typescript/scripts/build.js --ext .ts,.js passed.

I also attempted local builds:

• npm run build --workspace=packages/sdk-typescript still fails locally earlier in SDK TypeScript checks under src/daemon/events.ts / missing @qwen-code/acp-bridge/* declarations, before reaching the bundle-size guard.
• npm run build --workspace=packages/cli is still killed by SIGKILL in this low-memory environment during tsc --build.

Addressed the latest unresolved review follow-ups in 25903a1.

Summary:

• Reused resolveUpdateCommand in handleAutoUpdate so startup auto-update, qwen update, and /update share the same @latest / nightly replacement logic.
• Added CLI coverage for the updateMessage without updateCommand branch.
• Added /update coverage for interactive mode with enableAutoUpdate: false, confirming it returns manual update guidance instead of delegating to handleAutoUpdate.
• Relaxed the Unix shell path guard for single-quoted wrapper/PATH entries while still rejecting NUL/newline characters, with regression coverage for $ paths.
• Switched the Unix tar extraction filter base to fs.realpathSync(destDir) to match the Windows path and handle symlinked extraction destinations consistently.

Verification:

• npx vitest run src/commands/update.test.ts src/ui/commands/update-command.test.ts src/utils/standalone-update.test.ts src/utils/handleAutoUpdate.test.ts --pool=forks --poolOptions.forks.singleFork=true passed: 57 tests, 13 skipped.
• npx eslint packages/cli/src/utils/handleAutoUpdate.ts packages/cli/src/utils/handleAutoUpdate.test.ts packages/cli/src/utils/standalone-update.ts packages/cli/src/utils/standalone-update.test.ts packages/cli/src/commands/update.test.ts packages/cli/src/ui/commands/update-command.test.ts --ext .ts passed.

Note: npm run typecheck --workspace=packages/cli --if-present still fails locally on existing core/CLI API mismatches outside this change (findExistingProviderModels, normalizeClaudeMcpServer, MCP resource helper exports, and RewindRequest.rewindFiles).

Resolved the addressed review threads. Please continue reviewing when you have a chance.

@qwen-code /triage

@qwen-code /resolve

Qwen Code resolved the merge conflicts and pushed the branch update.

Merge Conflict Resolution Summary — PR #5780

Conflicts Found

11 files had merge conflicts between the PR branch and origin/main:

1. packages/cli/src/ui/startInteractiveUI.tsx (2 conflicts)

• Imports (line 30): HEAD added checkForUpdatesDetailed, handleAutoUpdate, and updateEventEmitter imports. origin/main had no new imports. Resolution: Kept HEAD's imports (they're part of the update feature).
• Body (line 216): HEAD added an update-check block (if (settings.merged.general?.enableAutoUpdate !== false) { checkForUpdatesDetailed()... }). origin/main added a startPostRenderPrefetches() call. Resolution: Kept both — they're independent features that should coexist. The update check runs first, then startPostRenderPrefetches follows.

2. packages/cli/src/gemini.test.tsx (4 conflicts)

• Mock setup (line 1910): HEAD added vi.mock() for updateCheck.js and updateEventEmitter.js. origin/main had nothing. Resolution: Kept HEAD's mocks.
• Import in test (line 1977): HEAD imported checkForUpdatesDetailed in the startup-tasks test. origin/main had nothing. Resolution: Kept HEAD's import.
• Test body + new tests (line 2008): HEAD added checkForUpdatesDetailed assertion and opened a "should not call checkForUpdates" test. origin/main added mockStartPostRenderPrefetches assertion and opened a "can skip post-render IDE connection" test. Resolution: Combined both assertions in the "should perform all startup tasks" test, then included both complete new tests with their proper setups.
• Auto-update test + error test (line 2083): HEAD added checkForUpdatesDetailed NOT-called assertion and a "should surface startup update check errors" test. origin/main added mockStartPostRenderPrefetches assertion for the same test. Resolution: Kept both assertions in the "delegates auto-update gating" test, then included HEAD's error-surfacing test.

3. packages/cli/src/i18n/locales/*.js (9 fi

@qwen-code /triage

Suggestions — commit 30a6b701ccab198bb09092d5319530248c22be58

• packages/cli/src/utils/standalone-update.ts:497 — acquireLock fast-path lock release on checkDeferredSwap throw is untested. Add a test: create a .new directory (no pre-existing lock), call acquireLock, expect throw, then assert the lock file was cleaned up (fs.existsSync(lockPath) is false).

— qwen3.7-max via Qwen Code /review

@qwen-code /triage