Fix auth UI to use semantic theme colors and correct selection sync#1823
Merged
Fix auth UI to use semantic theme colors and correct selection sync#1823
Conversation
- Replace hardcoded Colors.* with theme.* in AuthDialog and ApiKeyInput - Fix selectedIndex reset when going back from API-KEY sub-view to main view Co-authored-by: Qwen-Coder <[email protected]>
Contributor
📋 Review SummaryThis PR successfully migrates hardcoded color values to semantic theme colors in authentication UI components and fixes a UI synchronization issue. The changes improve theme consistency and ensure proper UI behavior when navigating between views. 🔍 General Feedback
🎯 Specific Feedback🔴 CriticalNo specific issues identified in this review. 🟡 HighNo specific issues identified in this review. 🟢 MediumNo specific issues identified in this review. 🔵 Low
✅ Highlights
|
Contributor
Code Coverage Summary
CLI Package - Full Text ReportCore Package - Full Text ReportFor detailed HTML reports, please see the 'coverage-reports-22.x-ubuntu-latest' artifact from the main CI run. |
Collaborator
yiliang114
approved these changes
Feb 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

TLDR
Replaces hardcoded color values with semantic theme colors in authentication UI components (
AuthDialog.tsxandApiKeyInput.tsx). Also fixes a UI synchronization issue where the selected authentication option and tip text would be out of sync when navigating back from the API-KEY sub-view.Dive Deeper
This change migrates the authentication dialogs to use the semantic color system (
theme.text.secondary,theme.status.error, etc.) instead of hardcoded color constants (Colors.Gray,Colors.AccentRed, etc.). This ensures consistent theming across the application and allows colors to adapt to different themes (light, dark, ANSI).Color mapping changes:
Colors.Gray→theme.text.secondaryColors.AccentYellow→theme.status.warningColors.AccentGreen→theme.status.successColors.AccentRed→theme.status.errorColors.AccentPurple→theme.text.accentColors.AccentBlue→theme.text.linkBug fix: When navigating back from the API-KEY sub-view to the main authentication view, the
selectedIndexstate is now reset tonull. This ensures the UI displays the correct initial selection and matching tip text instead of showing a mismatch between the highlighted option and the descriptive text.Reviewer Test Plan
npm run buildto ensure the code compiles without errorsnpm run lintto verify no linting issuesTesting Matrix
Linked issues / bugs