test: Add regression tests for constant folding panics#1476
Merged
Conversation
ss2165
reviewed
Mar 26, 2026
hugr-passes/src/const_fold/test.rs
Outdated
| /// Check that opaque constants don't cause panics when they fail to be folded. | ||
| // | ||
| // TODO: The disabled tests here are waiting for | ||
| //<https://github.com/Quantinuum/hugr/pull/2986> to be merged and released. |
Member
There was a problem hiding this comment.
expect fail better than disable?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1476 +/- ##
==========================================
+ Coverage 83.60% 83.62% +0.01%
==========================================
Files 187 187
Lines 28791 28796 +5
Branches 27800 27805 +5
==========================================
+ Hits 24071 24080 +9
+ Misses 3556 3553 -3
+ Partials 1164 1163 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ss2165
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #1473
The actual fixes are in Quantinuum/hugr#2986