Conversation
aborgna-q
force-pushed
the
ab/hugr-0.26.0
branch
from
aeb46d3 to
82495c1
Compare
This was referenced Mar 16, 2026
Collaborator
Author
|
Asking for a review before merging the LLVM update from #1422 into this branch. |
BREAKING CHANGE: The hugr-llvm LLVM version is being upgraded to 21.1, and code that depends on it here needs to be updated as well. This also includes an MSRV change to 1.91 to match hugr. See [the hugr PR](Quantinuum/hugr#2901) for details. Closes #1421 --------- Co-authored-by: Jake Arkinstall <[email protected]> Co-authored-by: Agustín Borgna <[email protected]>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1448 +/- ##
==========================================
- Coverage 79.65% 79.53% -0.13%
==========================================
Files 155 155
Lines 20335 20245 -90
Branches 19345 19254 -91
==========================================
- Hits 16197 16101 -96
- Misses 3180 3191 +11
+ Partials 958 953 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Collaborator
|
This PR contains breaking changes to the public Rust API. cargo-semver-checks summary |
aborgna-q
force-pushed
the
ab/hugr-0.26.0
branch
from
58e75da to
45b7d1e
Compare
aborgna-q
force-pushed
the
ab/hugr-0.26.0
branch
from
45b7d1e to
e5766ff
Compare
Collaborator
Author
|
I had to skip the I suspect it's due to the pass scope configuration in |
aborgna-q
force-pushed
the
ab/hugr-0.26.0
branch
4 times, most recently
from
7c55c3c to
c42afe0
Compare
aborgna-q
force-pushed
the
ab/hugr-0.26.0
branch
5 times, most recently
from
e4d4905 to
cb4d32c
Compare
aborgna-q
force-pushed
the
ab/hugr-0.26.0
branch
from
cb4d32c to
2b29cdb
Compare
Collaborator
Author
|
I disabled the linux ARM qis-compiler builds for now, while we wait for the custom LLVM builds on lower glibc. I think this should be ready to merge now. |
cqc-alec
approved these changes
Mar 19, 2026
| manylinux-aarch64-image = "manylinux_2_28" | ||
|
|
||
| # TODO: This has been temporarily bumped to get the tests working after the | ||
| # update to LLVM 21. This needs to go back to 'manylinux_2_28' before release. |
Collaborator
There was a problem hiding this comment.
Should make an issue for this if there isn't one already.
| // and is the best way to do so. | ||
| // This was written when using LLVM14, so we used 3 `feq`s. | ||
| // | ||
| // TODO: We now use LLVM21. Update this accordingly. |
Collaborator
There was a problem hiding this comment.
Worth making a github issue for this?
This was referenced Mar 16, 2026
Draft
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates the hugr dependencies to
0.26.0, and fixes all the breaking changes.I only added no-op stubs implementing
WithScopefor the local passes.We will add the actual implementation in #1429.
Requires updating LLVM too, so we should merge #1422 into this PR. We also need to delete the now removed
stack_arraylowering.BREAKING CHANGE: Updated public
hugrdependency to0.26.0.Requires a
hugr-passes 0.26.1patch release to include Quantinuum/hugr#2954Closes #1444