Skip to content

fix: Incorrect manylinux version in linux wheels#1327

Merged
aborgna-q merged 2 commits intomainfrom
ab/fix-manylinux-version
Dec 18, 2025
Merged

fix: Incorrect manylinux version in linux wheels#1327
aborgna-q merged 2 commits intomainfrom
ab/fix-manylinux-version

Conversation

@aborgna-q
Copy link
Copy Markdown
Collaborator

@aborgna-q aborgna-q commented Dec 17, 2025

The linux-gnu wheel builds were incorrectly stating we support manylinux2014 (glibc 2.17).
The wheels include the tket-c-api library, which is built directly on the container and hence uses the system's glibc version.

For the supported ubuntu 24.04 runner, that is glibc 2.39.
After some investigation, it seems that if we change the conan profile used to build tket-c-api from -gcc14 to -gcc13 the resulting .so only requires glibc 2.34.

This is just a patch to ensure the wheels we built correctly announce their properties.
The issue for actually fixing the root problem is here: #1272

Test build

@aborgna-q aborgna-q force-pushed the ab/fix-manylinux-version branch 6 times, most recently from 0b7e052 to 8670e61 Compare December 17, 2025 17:02
@aborgna-q aborgna-q force-pushed the ab/fix-manylinux-version branch from 8670e61 to 93253b1 Compare December 17, 2025 17:08
@aborgna-q aborgna-q marked this pull request as ready for review December 18, 2025 11:31
@aborgna-q aborgna-q requested a review from a team as a code owner December 18, 2025 11:31
@aborgna-q aborgna-q requested review from acl-cqc and ss2165 and removed request for acl-cqc December 18, 2025 11:31
@aborgna-q aborgna-q added this pull request to the merge queue Dec 18, 2025
@aborgna-q aborgna-q removed this pull request from the merge queue due to a manual request Dec 18, 2025
@aborgna-q aborgna-q changed the title ci: Fix manylinux version in linux wheels fix: Incorrect manylinux version in linux wheels Dec 18, 2025
@aborgna-q aborgna-q enabled auto-merge December 18, 2025 11:52
@aborgna-q aborgna-q added this pull request to the merge queue Dec 18, 2025
Merged via the queue into main with commit 073142c Dec 18, 2025
32 checks passed
@aborgna-q aborgna-q deleted the ab/fix-manylinux-version branch December 18, 2025 11:53
github-merge-queue bot pushed a commit that referenced this pull request Jan 15, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.12.14](tket-py-v0.12.13...tket-py-v0.12.14)
(2026-01-15)


### Features

* make PytketHugrPass store a list of passes
([#1360](#1360))
([498dd3a](498dd3a))
* Reduced glibc version requirement to 2.34
([#1327](#1327))
([498dd3a](498dd3a))
* Remove order edges in NormalizeGuppy pass
([#1326](#1326))
([dbfffd5](dbfffd5)),
closes [#1325](#1325)
* Use constant folding by default on NormalizeGuppy
([#1323](#1323))
([6f11024](6f11024))


### Bug Fixes

* Incorrect manylinux version in linux wheels
([#1327](#1327))
([498dd3a](498dd3a))
* Wrongly reused qubit IDs in pytket encoding
([#1358](#1358))
([498dd3a](498dd3a))


### Documentation

* update example notebook after Guppy optimization fixes
([#1357](#1357))
([7487e3a](7487e3a))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants