test: regenerate guppy_opt examples, and count gates by acl-cqc · Pull Request #1249 · Quantinuum/tket2

acl-cqc · 2025-11-11T18:10:13Z

The first part here is identical to examples from #1221 but I also needed myself. The second part....well, revealed why we need the first (I think updating to include Quantinuum/guppylang#1311 is particularly important) - DCE was taking out the gates because we were not doing anything to keep the result ops (!).

codecov · 2025-11-11T18:14:31Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 78.87%. Comparing base (6bc3c4e) to head (cc91af4).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1249      +/-   ##
==========================================
- Coverage   79.06%   78.87%   -0.19%     
==========================================
  Files         160      160              
  Lines       20421    20420       -1     
  Branches    19489    19489              
==========================================
- Hits        16145    16106      -39     
- Misses       3289     3324      +35     
- Partials      987      990       +3

Flag	Coverage Δ
rust	`78.19% <ø> (-0.20%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

aborgna-q · 2025-11-12T10:20:39Z

tket-qsystem/tests/guppy_opt.rs

+#[case::simple_cx(guppy_simple_cx(), (4, 2))]
 #[cfg_attr(miri, ignore)] // Opening files is not supported in (isolated) miri
-fn optimise_guppy(#[case] mut hugr: Hugr) {
+fn optimise_guppy(#[case] mut hugr: Hugr, #[case] before: (usize, usize)) {


Try to document the tuple values?

It could be two parameters, or a helper Counts struct instead

Suggested change

fn optimise_guppy(#[case] mut hugr: Hugr, #[case] before: (usize, usize)) {

fn optimise_guppy(#[case] mut hugr: Hugr, #[case] before @ (_non_alloc, _alloc): (usize, usize)) {

aborgna-q · 2025-11-12T10:21:23Z

tket-qsystem/tests/guppy_opt.rs

 #[case::nested(guppy_nested(), (6, 3))]
 #[case::ranges(guppy_ranges(), (8, 4))]
-#[case::simple_cx(guppy_simple_cx(), (0, 0))]
+#[case::simple_cx(guppy_simple_cx(), (4, 2))]


CalMacCQ · 2025-11-12T10:24:42Z

tket-qsystem/tests/guppy_opt.rs

    load_guppy_circuit("simple_cx")
 }

+fn count_gates(h: &impl HugrView) -> (usize, usize) {


Could be nice to have a comment explaining what this is counting and why.

As we dicussed in person it could be nice to have a map with keys as OpType and number of instances of the optypes values

## 🤖 New release * `tket`: 0.16.0 -> 0.17.0 (✓ API compatible changes) * `tket-qsystem`: 0.22.0 -> 0.23.0 (✓ API compatible changes) <details><summary>Changelog</summary> ## `tket` <blockquote> ## [0.17.0](tket-v0.16.0...tket-v0.17.0) - 2026-02-02 ### Bug Fixes - *(encoded-circ)* Track unsupported wires between input and output ([#1224](#1224)) - Multiple fixes to the pytket encoder ([#1226](#1226)) - Don't use opgroup in pytket barrier encoding ([#1251](#1251)) - guppy_to_circuit always returns num_operations = 0 ([#1200](#1200)) - *(pytket-decoder)* Avoid QAllocating and immediately freeing qubits ([#1256](#1256)) - Encoding of opaque subgraphs with no associated qubit/bit ([#1295](#1295)) - [**breaking**] Don't rely on command params for pytket barriers ([#1298](#1298)) - Track output qubits in CircuitInfo ([#1304](#1304)) - Wrongly reused qubit IDs in pytket encoding ([#1358](#1358)) ### New Features - Deprecate local find_tuple_unpack rewrite ([#1188](#1188)) - Add CopyableExpressionAST ([#1209](#1209)) - `NormalizeGuppy` pass to simplify generated structure ([#1220](#1220)) - [**breaking**] pytket EncodedCircuit struct for in-place pytket optimisation ([#1211](#1211)) - [**breaking**] Interval is independent of resource IDs and scope position ([#1205](#1205)) - Don't translate usizes to pytket ([#1241](#1241)) - BorrowSquashPass to elide redundant borrow/return ops ([#1159](#1159)) - [**breaking**] Bump hugr to 0.25.0 ([#1325](#1325)) - Remove order edges in NormalizeGuppy pass ([#1326](#1326)) - [**breaking**] Remove deprecated unpack tuple pass ([#1387](#1387)) ### Refactor - Remove contain_qubits, use TypeUnpacker ([#1283](#1283)) - [**breaking**] Replace Subcircuit with SiblingSubgraph ([#1288](#1288)) - *(metadata)* [**breaking**] Migrate all metadata keys onto the new metadata traits ([#1328](#1328)) </blockquote> ## `tket-qsystem` <blockquote> ## [0.23.0](tket-qsystem-v0.22.0...tket-qsystem-v0.23.0) - 2026-02-02 ### Bug Fixes - [**breaking**] Don't rely on command params for pytket barriers ([#1298](#1298)) - Wrongly reused qubit IDs in pytket encoding ([#1358](#1358)) ### New Features - `NormalizeGuppy` pass to simplify generated structure ([#1220](#1220)) - Allow running arbitrary serializable pytket passes on hugrs ([#1266](#1266)) - BorrowSquashPass to elide redundant borrow/return ops ([#1159](#1159)) - [**breaking**] Bump hugr to 0.25.0 ([#1325](#1325)) - Remove order edges in NormalizeGuppy pass ([#1326](#1326)) - hide new public funcs introduced by linearization ([#1333](#1333)) ### Testing - regenerate guppy_opt examples, and count gates ([#1249](#1249)) - run pytket on guppy_opt tests, measure (very limited) success ([#1250](#1250)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).

acl-cqc added 4 commits November 11, 2025 17:57

Count gates in whole Hugr after guppy opts but before pytket

563fc40

regenerate guppy_optimization test hugrs...used guppylang 0.21.6

e388a8f

Update guppylang requirement (regeneration did nothing)

416ace1

Correct counts

c921347

acl-cqc changed the title ~~tests: regenarate examples, and count gates~~ test: regenerate guppy_opt examples, and count gates Nov 11, 2025

acl-cqc requested review from CalMacCQ and aborgna-q November 11, 2025 18:15

acl-cqc marked this pull request as ready for review November 11, 2025 18:17

acl-cqc requested a review from a team as a code owner November 11, 2025 18:17

This was referenced Nov 11, 2025

feat: add some tests for guppy 1q squashing #1221

Open

test: run pytket on guppy_opt tests, measure (very limited) success #1250

Merged

aborgna-q approved these changes Nov 12, 2025

View reviewed changes

CalMacCQ reviewed Nov 12, 2025

View reviewed changes

count_gates returns map

8974ab5

CalMacCQ approved these changes Nov 12, 2025

View reviewed changes

acl-cqc added 2 commits November 12, 2025 15:32

Merge remote-tracking branch 'origin/main' into HEAD

b46f5a0

tidies

cc91af4

acl-cqc added this pull request to the merge queue Nov 12, 2025

acl-cqc removed this pull request from the merge queue due to a manual request Nov 12, 2025

aborgna-q approved these changes Nov 12, 2025

View reviewed changes

acl-cqc enabled auto-merge November 12, 2025 15:58

acl-cqc added this pull request to the merge queue Nov 12, 2025

Merged via the queue into main with commit fffb14a Nov 12, 2025
25 checks passed

acl-cqc deleted the acl/guppy_opt_counts branch November 12, 2025 16:02

hugrbot mentioned this pull request Nov 11, 2025

chore: release #1189

Merged

hugrbot mentioned this pull request Feb 5, 2026

chore: release #1394

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: regenerate guppy_opt examples, and count gates#1249

test: regenerate guppy_opt examples, and count gates#1249
acl-cqc merged 7 commits intomainfrom
acl/guppy_opt_counts

acl-cqc commented Nov 11, 2025 •

edited

Loading

Uh oh!

codecov bot commented Nov 11, 2025 •

edited

Loading

Uh oh!

aborgna-q Nov 12, 2025

Uh oh!

aborgna-q Nov 12, 2025

Uh oh!

CalMacCQ Nov 12, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	fn optimise_guppy(#[case] mut hugr: Hugr, #[case] before: (usize, usize)) {
	fn optimise_guppy(#[case] mut hugr: Hugr, #[case] before @ (_non_alloc, _alloc): (usize, usize)) {

Conversation

acl-cqc commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Nov 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

aborgna-q Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

aborgna-q Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

CalMacCQ Nov 12, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

acl-cqc commented Nov 11, 2025 •

edited

Loading

codecov bot commented Nov 11, 2025 •

edited

Loading