feat: Add CopyableExpressionAST by lmondada · Pull Request #1209 · Quantinuum/tket2

lmondada · 2025-10-28T14:32:03Z

I want to define a Subcircuit as a combination of Intervals on resource paths (the parts with linear, non-copyable data), and ASTs of fully classical, copyable data.

PR feat!: Interval is independent of resource IDs and scope position #1205 was opened to refine the notion of Interval
this PR creates the CopyableExpressionAST type that corresponds to ASTs of classical data in hugr graphs.

codecov · 2025-10-28T14:36:23Z

Codecov Report

❌ Patch coverage is 93.53234% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.97%. Comparing base (d34b013) to head (c7278d6).
⚠️ Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
tket/src/subcircuit/expression.rs	94.35%	9 Missing and 1 partial ⚠️
tket/src/resource/scope.rs	87.50%	3 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1209      +/-   ##
==========================================
+ Coverage   78.77%   78.97%   +0.20%     
==========================================
  Files         153      154       +1     
  Lines       18910    19111     +201     
  Branches    17808    18009     +201     
==========================================
+ Hits        14896    15093     +197     
- Misses       3070     3076       +6     
+ Partials      944      942       -2

Flag	Coverage Δ
python	`92.65% <ø> (ø)`
qis-compiler	`68.40% <ø> (ø)`
rust	`78.59% <93.53%> (+0.21%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

acl-cqc

I've suggested a lot of renamings and minor stuff, but nothing major, so I guess I'm happy for this to go in, but with the proviso...

...that I am still not certain whether we shouldn't have a single SiblingSubgraph for all the classical computation associated with a set of intervals rather than many potentially-overlapping ones...maybe I would need to see some examples

tket/src/subcircuit/expression.rs

lmondada · 2025-10-30T08:17:56Z

not certain whether we shouldn't have a single SiblingSubgraph for all the classical computation associated with a set of intervals rather than many potentially-overlapping ones...

I agree that the fact that multiple copyable expressions might have overlapping nodes is not great. That being said

your suggestion would require removing the convexity assumption (and enforcement) of [SiblingSubgraph] in hugr. This move would be quite breaking and should be thought through well. Might be something to add to clean-up november+december 😅 I agree that if non-convex SiblingSubgraphs existed, we could design this differently
You'll see in the upcoming Subcircuit PR that these (overlapping) copyable expressions are not stored within the subcircuit -- they are constructed on the fly from the set of inputs of the subcircuit. In other words, they are not part of the data of the subcircuit, but are much more like computable properties of the subcircuit. Thus, the fact that overlapping expressions can be produced depending on which copyable values we are interested in is not so concerning.

Overall, I agree that there are further follow-ups and clean-ups that should be considered and executed, but this is a step in the right direction: it's helping construct a layer of abstraction above SiblingSubgraph, which is badly needed.

lmondada · 2025-10-30T08:18:19Z

Thanks a lot Alan for the review!! Will now go through your comments and merge this in.

Co-authored-by: Alan Lawrence <[email protected]>

## 🤖 New release * `tket`: 0.16.0 -> 0.17.0 (✓ API compatible changes) * `tket-qsystem`: 0.22.0 -> 0.23.0 (✓ API compatible changes) <details><summary>Changelog</summary> ## `tket` <blockquote> ## [0.17.0](tket-v0.16.0...tket-v0.17.0) - 2026-02-02 ### Bug Fixes - *(encoded-circ)* Track unsupported wires between input and output ([#1224](#1224)) - Multiple fixes to the pytket encoder ([#1226](#1226)) - Don't use opgroup in pytket barrier encoding ([#1251](#1251)) - guppy_to_circuit always returns num_operations = 0 ([#1200](#1200)) - *(pytket-decoder)* Avoid QAllocating and immediately freeing qubits ([#1256](#1256)) - Encoding of opaque subgraphs with no associated qubit/bit ([#1295](#1295)) - [**breaking**] Don't rely on command params for pytket barriers ([#1298](#1298)) - Track output qubits in CircuitInfo ([#1304](#1304)) - Wrongly reused qubit IDs in pytket encoding ([#1358](#1358)) ### New Features - Deprecate local find_tuple_unpack rewrite ([#1188](#1188)) - Add CopyableExpressionAST ([#1209](#1209)) - `NormalizeGuppy` pass to simplify generated structure ([#1220](#1220)) - [**breaking**] pytket EncodedCircuit struct for in-place pytket optimisation ([#1211](#1211)) - [**breaking**] Interval is independent of resource IDs and scope position ([#1205](#1205)) - Don't translate usizes to pytket ([#1241](#1241)) - BorrowSquashPass to elide redundant borrow/return ops ([#1159](#1159)) - [**breaking**] Bump hugr to 0.25.0 ([#1325](#1325)) - Remove order edges in NormalizeGuppy pass ([#1326](#1326)) - [**breaking**] Remove deprecated unpack tuple pass ([#1387](#1387)) ### Refactor - Remove contain_qubits, use TypeUnpacker ([#1283](#1283)) - [**breaking**] Replace Subcircuit with SiblingSubgraph ([#1288](#1288)) - *(metadata)* [**breaking**] Migrate all metadata keys onto the new metadata traits ([#1328](#1328)) </blockquote> ## `tket-qsystem` <blockquote> ## [0.23.0](tket-qsystem-v0.22.0...tket-qsystem-v0.23.0) - 2026-02-02 ### Bug Fixes - [**breaking**] Don't rely on command params for pytket barriers ([#1298](#1298)) - Wrongly reused qubit IDs in pytket encoding ([#1358](#1358)) ### New Features - `NormalizeGuppy` pass to simplify generated structure ([#1220](#1220)) - Allow running arbitrary serializable pytket passes on hugrs ([#1266](#1266)) - BorrowSquashPass to elide redundant borrow/return ops ([#1159](#1159)) - [**breaking**] Bump hugr to 0.25.0 ([#1325](#1325)) - Remove order edges in NormalizeGuppy pass ([#1326](#1326)) - hide new public funcs introduced by linearization ([#1333](#1333)) ### Testing - regenerate guppy_opt examples, and count gates ([#1249](#1249)) - run pytket on guppy_opt tests, measure (very limited) success ([#1250](#1250)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).

lmondada force-pushed the lm/copyable-expr-pr branch from 3249a88 to 16e358a Compare October 28, 2025 14:33

lmondada force-pushed the lm/copyable-expr-pr branch 2 times, most recently from cadeb13 to 244a2f8 Compare October 28, 2025 14:39

feat: Add CopyableExpressionAST

0ba8534

lmondada force-pushed the lm/copyable-expr-pr branch from 244a2f8 to 0ba8534 Compare October 28, 2025 14:49

lmondada marked this pull request as ready for review October 28, 2025 14:49

lmondada requested a review from a team as a code owner October 28, 2025 14:49

lmondada requested review from acl-cqc and cqc-alec and removed request for cqc-alec October 28, 2025 14:49

convexity test

bd71274

acl-cqc approved these changes Oct 29, 2025

View reviewed changes

lmondada and others added 4 commits October 30, 2025 09:18

Update tket/src/subcircuit/expression.rs

6766a00

Co-authored-by: Alan Lawrence <[email protected]>

Update tket/src/subcircuit/expression.rs

7a81981

Co-authored-by: Alan Lawrence <[email protected]>

Update tket/src/subcircuit/expression.rs

e08d820

Co-authored-by: Alan Lawrence <[email protected]>

address comments

c7278d6

lmondada enabled auto-merge October 30, 2025 11:04

lmondada added this pull request to the merge queue Oct 30, 2025

Merged via the queue into main with commit 52fc658 Oct 30, 2025
24 checks passed

lmondada deleted the lm/copyable-expr-pr branch October 30, 2025 11:12

hugrbot mentioned this pull request Oct 27, 2025

chore: release #1189

Merged

hugrbot mentioned this pull request Feb 5, 2026

chore: release #1394

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add CopyableExpressionAST#1209

feat: Add CopyableExpressionAST#1209
lmondada merged 6 commits intomainfrom
lm/copyable-expr-pr

lmondada commented Oct 28, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 28, 2025 •

edited

Loading

Uh oh!

acl-cqc left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lmondada commented Oct 30, 2025

Uh oh!

lmondada commented Oct 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

lmondada commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

acl-cqc left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

lmondada commented Oct 30, 2025

Uh oh!

lmondada commented Oct 30, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

lmondada commented Oct 28, 2025 •

edited

Loading

codecov bot commented Oct 28, 2025 •

edited

Loading