Skip to content

fix: allow both _composable_pass and composable_pass imports#2965

Merged
aborgna-q merged 4 commits intomainfrom
fix/alias_composable_pass
Mar 19, 2026
Merged

fix: allow both _composable_pass and composable_pass imports#2965
aborgna-q merged 4 commits intomainfrom
fix/alias_composable_pass

Conversation

@CalMacCQ
Copy link
Copy Markdown
Contributor

@CalMacCQ CalMacCQ commented Mar 18, 2026

resolves breakage in #2962 by allowing both from _composable_pass and from composable_pass imports. This is a problem as in tket-py we access the private module _composable_pass for the implementation of PytketHugrPass (not the best practice on my part).

I've added a duplicate _composable_pass.py file now with a wildcard import (gross)

Will remove this once we have _composable_pass usage removed from tket-py. There shouldn't be any _scope usage in the tket-py main branch.

Theres probably a nicer way to do this with something like

import sys
sys.modules["_foo"] = sys.modules[__name__]

However this wasn't immediately working for me.

Related #2961

@CalMacCQ CalMacCQ requested a review from a team as a code owner March 18, 2026 17:50
@CalMacCQ CalMacCQ requested review from doug-q and maximilianruesch and removed request for doug-q March 18, 2026 17:50
@CalMacCQ
Copy link
Copy Markdown
Contributor Author

I'm on holiday tomorrow so feel free to edit/merge in my absence if need be.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 18, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.87%. Comparing base (856f92d) to head (badc4d2).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2965   +/-   ##
=======================================
  Coverage   83.87%   83.87%           
=======================================
  Files         267      268    +1     
  Lines       52943    52945    +2     
  Branches    46857    46857           
=======================================
+ Hits        44408    44410    +2     
  Misses       6266     6266           
  Partials     2269     2269           
Flag Coverage Δ
python 88.84% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

import pytest

from hugr.hugr.base import Hugr
from hugr.passes._composable_pass import *
Copy link
Copy Markdown
Contributor Author

@CalMacCQ CalMacCQ Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added this extra line to test that you can actually use both import paths.

@CalMacCQ CalMacCQ changed the title fix: allow _composable_pass and composable_pass imports fix: allow both _composable_pass and composable_pass imports Mar 18, 2026
@aborgna-q aborgna-q added this pull request to the merge queue Mar 19, 2026
Merged via the queue into main with commit 0a5664d Mar 19, 2026
29 checks passed
@aborgna-q aborgna-q deleted the fix/alias_composable_pass branch March 19, 2026 15:02
github-merge-queue bot pushed a commit that referenced this pull request Mar 31, 2026
Allowing both `_scope` and `scope` imports following #2965. 

It turns out that `_scope` this is used in a single place in the tket2
repo. I thought I checked that it was unused. Either I missed it or it
has started to be used since I checked somehow.
github-merge-queue bot pushed a commit that referenced this pull request Apr 1, 2026
🤖 I have created a release *beep* *boop*
---


##
[0.16.0](hugr-py-v0.15.4...hugr-py-v0.16.0)
(2026-04-01)

This release changes the default text serialization format from JSON to
`MODEL_WITH_EXTS` (the JSON format is now deprecated).
It also adds the ability to link packages and modules from Python,
renders operation type arguments in HUGR visualizations, introduces a
new `debug_info` module for attaching source-level debug metadata to
nodes,
and introduces multi-version support in `ExtensionRegistry`, allowing
different versions of the same extension to coexist in the same
registry.


### ⚠ BREAKING CHANGES

* `ExtensionRegistry` may now contain multiple versions of the same
extension. `.extensions` is now an iterator of the latest versions
instead of a dictionary. `.register_updated` and `.add_extension` have
been replaced with a singular `.register`.
* Default `EnvelopeConfig` changed from `EnvelopeFormat.JSON` to
`EnvelopeFormat.MODEL_WITH_EXTS`.
* Substituted `hugr-py/src/hugr/tys.py::_type_str` with
`hugr-py/src/hugr/utils.py::name_w_args`.

### Features

* Add debug info metadata specification in `hugr-py`
([#2971](#2971))
([a4da8ef](a4da8ef))
* Allow multiple versions of an extension in an ExtensionRegistry
([#3005](#3005))
([ee90cd1](ee90cd1))
* Deprecate JSON serialization format
([#2991](#2991))
([0f7a880](0f7a880))
* Operation parameter rendering in HUGR visualizations
([#2995](#2995))
([d619148](d619148))
* Allow linking packages and modules from Python
([#2947](#2947))
([329c243](329c243))
* Make `_composable_pass` and `_scope` public modules
([#2962](#2962))
([1d6af9a](1d6af9a)),
closes [#2961](#2961)
* Allow missing ext versions ExtensionDesc metadata
([#2979](#2979))
([bc1c445](bc1c445))
* Allow dfg conversion in to TrackedDfg
([#2993](#2993))
([3bd7a88](3bd7a88))


### Bug Fixes

* Allow both _composable_pass and composable_pass imports
([#2965](#2965))
([0a5664d](0a5664d))
* Allow both _scope and scope imports
([#3003](#3003))
([de0458c](de0458c))
* Always do extension resolution when loading packages and hugrs
([#2953](#2953))
([0086d2a](0086d2a))
* Correct pyo3 module definitions and add missing exception class export
([#2964](#2964))
([3df73f4](3df73f4))
* Include extensions during link serialization
([#2992](#2992))
([9236e89](9236e89))
* Prefix names with underscores during serialization
([#2989](#2989))
([8aab636](8aab636))
* Use valid identifiers when constructing AST model
([#2973](#2973))
([8750a6b](8750a6b))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Agustín Borgna <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants