ci: Don't compile hugr-llvm on required stable checks#2936
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2936 +/- ##
==========================================
+ Coverage 83.78% 83.82% +0.04%
==========================================
Files 267 267
Lines 52960 52996 +36
Branches 46899 46935 +36
==========================================
+ Hits 44372 44424 +52
+ Misses 6318 6302 -16
Partials 2270 2270
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| uses: quantinuum/hugrverse-actions/.github/workflows/rs-semver-checks.yml@main | ||
| secrets: | ||
| GITHUB_PAT: ${{ secrets.HUGRBOT_PAT }} | ||
| # once llvm-21 is packaged on apt, we could just download it using 'apt-dependencies' |
There was a problem hiding this comment.
Not sure if this is preferable, but it should already be possible; we'd just need to add the llvm apt repository (see https://apt.llvm.org/). Something like this should do it:
wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
sudo add-apt-repository 'deb http://apt.llvm.org/noble/ llvm-toolchain-noble-21 main'
sudo apt update
sudo apt install llvm-21
(Not sure if we need llvm-21-dev too?)
There was a problem hiding this comment.
I'll merge this as-is, and see about using apt in the testing PR (#2934)
Co-authored-by: Alec Edgington <[email protected]>
Proper fix following from #2936. Manually installs LLVM from the `apt.llvm.org` repository instead of using `KyleMayes/install-llvm-action@v2`. I'm not sure of the reason, but this solves the issue of half-hour long build times. Additionally, we seem to be using `sscache` again in the builds.
2 participants
Build times for
--workspace --all-featureswent from >2mins to over 30mins after we merged #2901.It affected not only
hugr-llvmevery crate, but every dependant too;We are tracking down this issue, but in the meantime this PR removes the
hugr-llvmfeature from the stable required checks, so we can continue doing development without waiting hours to merge stuff.Here is a
cargo test --timingsexample:cargo-timing.html
I made a couple drive-byes to help with the still slow cases:
drive-by: Remove unneeded transitive
aws-lc-sysdependency, that was slow to compile.drive-by: Fix
rs-semver-checks. #2901 updated it in an incorrect waydrive-by: Add a concurrency limit to the rust checks workflow, so pushing new changes to a PR stops existing runs.