chore!: Fix new clippy warning on rust 1.94 by aborgna-q · Pull Request #2912 · Quantinuum/hugr

aborgna-q · 2026-03-02T10:39:31Z

Proper fix for #2911

Reduces the error size from 160B to 24B

BREAKING CHANGE: Changed type of HUGRSerializationError::MissingPortOffset::op_type from OpType to String.

codecov · 2026-03-02T10:47:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.83%. Comparing base (6240fbf) to head (8e10351).
⚠️ Report is 12 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2912   +/-   ##
=======================================
  Coverage   83.83%   83.83%           
=======================================
  Files         269      269           
  Lines       54018    54018           
  Branches    47971    47971           
=======================================
  Hits        45286    45286           
  Misses       6317     6317           
  Partials     2415     2415

Flag	Coverage Δ
python	`88.65% <ø> (ø)`
rust	`83.22% <100.00%> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

```bash error: the `Err`-variant returned from this closure is very large --> hugr-core/src/hugr/serialize.rs:288:71 | 123 | / MissingPortOffset { 124 | | /// The node that has the port without offset. 125 | | node: Node, 126 | | /// The direction of the port without an offset ... | 129 | | op_type: OpType, 130 | | }, | |_____- the largest variant contains at least 157 bytes ... 288 | let unwrap_offset = |node: Node, offset, dir, hugr: &Hugr| -> Result<usize, Self::Error> { | ^^^^^^^^^^^^^^^^^^^^^^^^^^ ``` The proper fix for this (boxing the `Optype` or changing it to a string) is a breaking change. See #2912.

## 🤖 New release * `hugr-model`: 0.25.7 -> 0.26.0 (✓ API compatible changes) * `hugr-core`: 0.25.7 -> 0.26.0 (⚠ API breaking changes) * `hugr-llvm`: 0.25.7 -> 0.26.0 (✓ API compatible changes) * `hugr-persistent`: 0.4.7 -> 0.5.0 (✓ API compatible changes) * `hugr`: 0.25.7 -> 0.26.0 (✓ API compatible changes) * `hugr-passes`: 0.25.7 -> 0.26.0 (⚠ API breaking changes) * `hugr-cli`: 0.25.7 -> 0.26.0 (✓ API compatible changes) ### ⚠ `hugr-core` breaking changes ```text --- failure enum_struct_variant_field_added: pub enum struct variant field added --- Description: An enum's exhaustive struct variant has a new field, which has to be included when constructing or matching on this variant. ref: https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/enum_struct_variant_field_added.ron Failed in: field pkg of variant LowerFunc::FixedHugr in /tmp/.tmpGqHhMb/hugr/hugr-core/src/extension/op_def.rs:312 --- failure enum_struct_variant_field_missing: pub enum struct variant's field removed or renamed --- Description: A publicly-visible enum has a struct variant whose field is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/enum_struct_variant_field_missing.ron Failed in: field hugr of variant LowerFunc::FixedHugr, previously in file /tmp/.tmpqeiszk/hugr-core/src/extension/op_def.rs:303 --- failure enum_variant_missing: pub enum variant removed or renamed --- Description: A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/enum_variant_missing.ron Failed in: variant BuildError::HugrInsertionError, previously in file /tmp/.tmpqeiszk/hugr-core/src/builder.rs:186 variant EnvelopeFormat::ModelText, previously in file /tmp/.tmpqeiszk/hugr-core/src/envelope/header.rs:60 variant EnvelopeFormat::ModelTextWithExtensions, previously in file /tmp/.tmpqeiszk/hugr-core/src/envelope/header.rs:70 variant Value::Function, previously in file /tmp/.tmpqeiszk/hugr-core/src/ops/constant.rs:169 variant Value::Function, previously in file /tmp/.tmpqeiszk/hugr-core/src/ops/constant.rs:169 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/function_missing.ron Failed in: function hugr_core::envelope::read_described_envelope, previously in file /tmp/.tmpqeiszk/hugr-core/src/envelope.rs:98 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/inherent_method_missing.ron Failed in: Value::function, previously in file /tmp/.tmpqeiszk/hugr-core/src/ops/constant.rs:380 Value::function, previously in file /tmp/.tmpqeiszk/hugr-core/src/ops/constant.rs:380 ``` ### ⚠ `hugr-passes` breaking changes ```text --- failure derive_trait_impl_removed: built-in derived trait no longer implemented --- Description: A public type has stopped deriving one or more traits. This can break downstream code that depends on those types implementing those traits. ref: https://doc.rust-lang.org/reference/attributes/derive.html#derive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/derive_trait_impl_removed.ron Failed in: type RedundantOrderEdgesPass no longer derives Copy, in /tmp/.tmpGqHhMb/hugr/hugr-passes/src/redundant_order_edges.rs:26 --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/enum_missing.ron Failed in: enum hugr_passes::untuple::UntupleRecursive, previously in file /tmp/.tmpqeiszk/hugr-passes/src/untuple.rs:23 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/function_missing.ron Failed in: function hugr_passes::remove_dead_funcs, previously in file /tmp/.tmpqeiszk/hugr-passes/src/dead_funcs.rs:179 function hugr_passes::const_fold::constant_fold_pass, previously in file /tmp/.tmpqeiszk/hugr-passes/src/const_fold.rs:224 function hugr_passes::non_local::nonlocal_edges, previously in file /tmp/.tmpqeiszk/hugr-passes/src/non_local.rs:39 function hugr_passes::nonlocal_edges, previously in file /tmp/.tmpqeiszk/hugr-passes/src/non_local.rs:39 function hugr_passes::monomorphize, previously in file /tmp/.tmpqeiszk/hugr-passes/src/monomorphize.rs:36 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/inherent_method_missing.ron Failed in: UntuplePass::new, previously in file /tmp/.tmpqeiszk/hugr-passes/src/untuple.rs:102 UntuplePass::set_parent, previously in file /tmp/.tmpqeiszk/hugr-passes/src/untuple.rs:114 UntuplePass::recursive, previously in file /tmp/.tmpqeiszk/hugr-passes/src/untuple.rs:136 UntuplePass::find_rewrites, previously in file /tmp/.tmpqeiszk/hugr-passes/src/untuple.rs:151 UntuplePass::new, previously in file /tmp/.tmpqeiszk/hugr-passes/src/untuple.rs:102 UntuplePass::set_parent, previously in file /tmp/.tmpqeiszk/hugr-passes/src/untuple.rs:114 UntuplePass::recursive, previously in file /tmp/.tmpqeiszk/hugr-passes/src/untuple.rs:136 UntuplePass::find_rewrites, previously in file /tmp/.tmpqeiszk/hugr-passes/src/untuple.rs:151 RedundantOrderEdgesPass::new, previously in file /tmp/.tmpqeiszk/hugr-passes/src/redundant_order_edges.rs:39 RedundantOrderEdgesPass::recursive, previously in file /tmp/.tmpqeiszk/hugr-passes/src/redundant_order_edges.rs:44 RemoveDeadFuncsPass::with_module_entry_points, previously in file /tmp/.tmpqeiszk/hugr-passes/src/dead_funcs.rs:75 NormalizeCFGPass::cfgs, previously in file /tmp/.tmpqeiszk/hugr-passes/src/normalize_cfgs.rs:121 ValueHandle::new_const_hugr, previously in file /tmp/.tmpqeiszk/hugr-passes/src/const_fold/value_handle.rs:95 --- failure trait_added_supertrait: non-sealed trait added new supertraits --- Description: A non-sealed trait added one or more supertraits, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#generic-bounds-tighten impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/trait_added_supertrait.ron Failed in: trait hugr_passes::composable::ComposablePass gained WithScope in file /tmp/.tmpGqHhMb/hugr/hugr-passes/src/composable.rs:25 trait hugr_passes::ComposablePass gained WithScope in file /tmp/.tmpGqHhMb/hugr/hugr-passes/src/composable.rs:25 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/trait_method_missing.ron Failed in: method value_from_const_hugr of trait ConstLoader, previously in file /tmp/.tmpqeiszk/hugr-passes/src/dataflow.rs:73 method with_scope_internal of trait ComposablePass, previously in file /tmp/.tmpqeiszk/hugr-passes/src/composable.rs:45 method with_scope_internal of trait ComposablePass, previously in file /tmp/.tmpqeiszk/hugr-passes/src/composable.rs:45 --- failure type_allows_fewer_generic_type_params: type now allows fewer generic type parameters --- Description: A type now allows fewer generic type parameters than it used to. Uses of this type that supplied all previously-supported generic types will be broken. ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-parameter-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/type_allows_fewer_generic_type_params.ron Failed in: Struct NormalizeCFGPass allows 1 -> 0 generic types in /tmp/.tmpGqHhMb/hugr/hugr-passes/src/normalize_cfgs.rs:101 --- failure unit_struct_changed_kind: unit struct changed kind --- Description: A public unit struct has been changed to a normal (curly-braces) struct, which cannot be constructed using the same struct literal syntax. ref: rust-lang/cargo#10871 impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.46.0/src/lints/unit_struct_changed_kind.ron Failed in: struct MonomorphizePass in /tmp/.tmpGqHhMb/hugr/hugr-passes/src/monomorphize.rs:178 struct InlineDFGsPass in /tmp/.tmpGqHhMb/hugr/hugr-passes/src/inline_dfgs.rs:17 struct LocalizeEdges in /tmp/.tmpGqHhMb/hugr/hugr-passes/src/non_local.rs:23 ``` <details><summary>Changelog</summary> ## `hugr-model` <blockquote> ## [0.26.0](hugr-model-v0.25.7...hugr-model-v0.26.0) - 2026-03-16 ### Testing - Replace model text snapshots with roundtrip tests ([#2933](#2933)) - Add missing width arg in model-call example ([#2945](#2945)) </blockquote> ## `hugr-core` <blockquote> ## [0.26.0](hugr-core-v0.25.7...hugr-core-v0.26.0) - 2026-03-16 ### Bug Fixes - Keep declared used_extensions in envelope description ([#2932](#2932)) ### Documentation - Move `spec/schema` and `spec/std_extensions` to `resources/` ([#2897](#2897)) ### Miscellaneous Tasks - [**breaking**] Fix new clippy warning on rust 1.94 ([#2912](#2912)) ### New Features - [**breaking**] Rename ModelText envelope format to SExpression ([#2927](#2927)) - [**breaking**] Fix lower_funcs with custom extensions failing to load ([#2925](#2925)) - [**breaking**] TypeRow: add impl From array of Type, remove From<Type> ([#2784](#2784)) - Deprecate HugrView::as_petgraph ([#2944](#2944)) ### Refactor - [**breaking**] Remove deprecated Value::Function ([#2928](#2928)) - [**breaking**] Remove deprecated definitions ([#2930](#2930)) ### Testing - Fix type_row intos in doctests ([#2941](#2941)) - Add missing width arg in model-call example ([#2945](#2945)) </blockquote> ## `hugr-llvm` <blockquote> ## [0.26.0](hugr-llvm-v0.25.7...hugr-llvm-v0.26.0) - 2026-03-16 ### New Features - *(llvm)* [**breaking**] Upgrade to LLVM 21 ([#2901](#2901)) - Include private HUGR functions in the local symbol table ([#2831](#2831)) - [**breaking**] TypeRow: add impl From array of Type, remove From<Type> ([#2784](#2784)) ### Refactor - [**breaking**] Remove deprecated Value::Function ([#2928](#2928)) - [**breaking**] Remove deprecated stack_array codegen ([#2929](#2929)) </blockquote> ## `hugr-persistent` <blockquote> ## [0.5.0](hugr-persistent-v0.4.7...hugr-persistent-v0.5.0) - 2026-03-16 ### New Features - *(llvm)* [**breaking**] Upgrade to LLVM 21 ([#2901](#2901)) - [**breaking**] TypeRow: add impl From array of Type, remove From<Type> ([#2784](#2784)) </blockquote> ## `hugr` <blockquote> ## [0.26.0](hugr-v0.25.7...hugr-v0.26.0) - 2026-03-16 ### Bug Fixes - Keep declared used_extensions in envelope description ([#2932](#2932)) ### Documentation - Move `spec/schema` and `spec/std_extensions` to `resources/` ([#2897](#2897)) ### Miscellaneous Tasks - [**breaking**] Fix new clippy warning on rust 1.94 ([#2912](#2912)) ### New Features - [**breaking**] Update remainder of passes to use PassScope, drop default with_scope ([#2871](#2871)) - [**breaking**] Make `WithScope` a supertrait of `ComposablePass` ([#2921](#2921)) - [**breaking**] Rename ModelText envelope format to SExpression ([#2927](#2927)) - [**breaking**] Fix lower_funcs with custom extensions failing to load ([#2925](#2925)) - Deprecate HugrView::as_petgraph ([#2944](#2944)) - [**breaking**] `hugr-passes` is no longer reexported from `hugr::algorithms` ([#2922](#2922)) - *(llvm)* [**breaking**] Upgrade to LLVM 21 ([#2901](#2901)) - [**breaking**] TypeRow: add impl From array of Type, remove From<Type> ([#2784](#2784)) ### Refactor - [**breaking**] Remove deprecated pass configuration ([#2938](#2938)) - [**breaking**] Remove deprecated Value::Function ([#2928](#2928)) - [**breaking**] Remove deprecated definitions ([#2930](#2930)) ### Testing - Fix type_row intos in doctests ([#2941](#2941)) - Add missing width arg in model-call example ([#2945](#2945)) </blockquote> ## `hugr-passes` <blockquote> ## [0.26.0](hugr-passes-v0.25.7...hugr-passes-v0.26.0) - 2026-03-16 ### New Features - [**breaking**] `hugr-passes` is no longer reexported from `hugr::algorithms` ([#2922](#2922)) - *(llvm)* [**breaking**] Upgrade to LLVM 21 ([#2901](#2901)) - [**breaking**] Update remainder of passes to use PassScope, drop default with_scope ([#2871](#2871)) - [**breaking**] Make `WithScope` a supertrait of `ComposablePass` ([#2921](#2921)) - [**breaking**] TypeRow: add impl From array of Type, remove From<Type> ([#2784](#2784)) - Deprecate HugrView::as_petgraph ([#2944](#2944)) ### Refactor - [**breaking**] Remove deprecated Value::Function ([#2928](#2928)) - [**breaking**] Remove deprecated pass configuration ([#2938](#2938)) </blockquote> ## `hugr-cli` <blockquote> ## [0.26.0](hugr-cli-v0.25.7...hugr-cli-v0.26.0) - 2026-03-16 ### Documentation - Move `spec/schema` and `spec/std_extensions` to `resources/` ([#2897](#2897)) ### New Features - [**breaking**] Rename ModelText envelope format to SExpression ([#2927](#2927)) - [**breaking**] TypeRow: add impl From array of Type, remove From<Type> ([#2784](#2784)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: Agustín Borgna <[email protected]> Co-authored-by: Alec Edgington <[email protected]>

aborgna-q added this to the hugr-rs 0.26.0 milestone Mar 2, 2026

aborgna-q requested a review from a team as a code owner March 2, 2026 10:39

aborgna-q requested review from croyzor and removed request for a team March 2, 2026 10:39

aborgna-q added the S-breaking-change Status: Need a breaking change release to progress label Mar 2, 2026

aborgna-q mentioned this pull request Mar 2, 2026

chore: Ignore new clippy warning on rust 1.94 #2911

Merged

aborgna-q force-pushed the ab/rust-1.94-proper-fix branch from 3c1c016 to f79b173 Compare March 2, 2026 11:02

aborgna-q changed the base branch from ab/rust-1.94 to main March 2, 2026 11:03

chore: Fix new clippy warning on rust 1.94

8e10351

aborgna-q force-pushed the ab/rust-1.94-proper-fix branch from f79b173 to 8e10351 Compare March 2, 2026 11:10

croyzor approved these changes Mar 2, 2026

View reviewed changes

aborgna-q changed the title ~~chore: Fix new clippy warning on rust 1.94~~ chore!: Fix new clippy warning on rust 1.94 Mar 2, 2026

aborgna-q added this pull request to the merge queue Mar 9, 2026

Merged via the queue into main with commit d65124c Mar 9, 2026
31 checks passed

aborgna-q deleted the ab/rust-1.94-proper-fix branch March 9, 2026 10:08

hugrbot mentioned this pull request Mar 9, 2026

chore: release #2926

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore!: Fix new clippy warning on rust 1.94#2912

chore!: Fix new clippy warning on rust 1.94#2912
aborgna-q merged 1 commit intomainfrom
ab/rust-1.94-proper-fix

aborgna-q commented Mar 2, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

aborgna-q commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

aborgna-q commented Mar 2, 2026 •

edited

Loading

codecov bot commented Mar 2, 2026 •

edited

Loading