Skip to content

chore: Ignore new clippy warning on rust 1.94#2911

Merged
aborgna-q merged 2 commits intomainfrom
ab/rust-1.94
Mar 2, 2026
Merged

chore: Ignore new clippy warning on rust 1.94#2911
aborgna-q merged 2 commits intomainfrom
ab/rust-1.94

Conversation

@aborgna-q
Copy link
Copy Markdown
Collaborator

@aborgna-q aborgna-q commented Mar 2, 2026

error: the `Err`-variant returned from this closure is very large
   --> hugr-core/src/hugr/serialize.rs:288:71
    |
123 | /     MissingPortOffset {
124 | |         /// The node that has the port without offset.
125 | |         node: Node,
126 | |         /// The direction of the port without an offset
...   |
129 | |         op_type: OpType,
130 | |     },
    | |_____- the largest variant contains at least 157 bytes
...
288 |           let unwrap_offset = |node: Node, offset, dir, hugr: &Hugr| -> Result<usize, Self::Error> {
    |                                                                         ^^^^^^^^^^^^^^^^^^^^^^^^^^

The proper fix for this (boxing the Optype or changing it to a string) is a breaking change. See #2912.

@aborgna-q aborgna-q requested a review from a team as a code owner March 2, 2026 10:32
@aborgna-q aborgna-q requested a review from doug-q March 2, 2026 10:32
@aborgna-q aborgna-q changed the title Ignore new clippy warning on rust 1.94 chore: Ignore new clippy warning on rust 1.94 Mar 2, 2026
@codecov
Copy link
Copy Markdown

codecov bot commented Mar 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.83%. Comparing base (d146ebc) to head (cb5f11d).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2911      +/-   ##
==========================================
+ Coverage   83.81%   83.83%   +0.01%     
==========================================
  Files         269      269              
  Lines       53967    54018      +51     
  Branches    47920    47971      +51     
==========================================
+ Hits        45235    45286      +51     
  Misses       6317     6317              
  Partials     2415     2415              
Flag Coverage Δ
python 88.65% <ø> (ø)
rust 83.22% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@aborgna-q aborgna-q requested review from cqc-alec and removed request for doug-q March 2, 2026 10:50
@aborgna-q aborgna-q enabled auto-merge March 2, 2026 10:59
@aborgna-q aborgna-q added this pull request to the merge queue Mar 2, 2026
Merged via the queue into main with commit 6240fbf Mar 2, 2026
31 checks passed
@aborgna-q aborgna-q deleted the ab/rust-1.94 branch March 2, 2026 11:07
github-merge-queue bot pushed a commit that referenced this pull request Mar 9, 2026
Proper fix for #2911 

Reduces the error size from `160B` to `24B`

BREAKING CHANGE: Changed type of
`HUGRSerializationError::MissingPortOffset::op_type` from `OpType` to
`String`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants