fix: set hugr field of PassResult correctly#2715
Merged
Conversation
CalMacCQ
requested review from
acl-cqc and
cqc-alec
and removed request for
cqc-alec
acl-cqc
approved these changes
Nov 26, 2025
Contributor
acl-cqc
left a comment
acl-cqc
left a comment
There was a problem hiding this comment.
Looks good thanks Callum!
Bonus points for improving the test that it would have spotted the problem before we fixed it ;-) :-)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2715 +/- ##
=======================================
Coverage 83.55% 83.55%
=======================================
Files 266 266
Lines 51761 51761
Branches 47180 47180
=======================================
Hits 43251 43251
Misses 6132 6132
Partials 2378 2378
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
acl-cqc
pushed a commit
that referenced
this pull request
Nov 26, 2025
This was referenced Nov 26, 2025
acl-cqc
pushed a commit
that referenced
this pull request
Nov 26, 2025
🤖 I have created a release *beep* *boop* --- ## [0.14.4](hugr-py-v0.14.3...hugr-py-v0.14.4) (2025-11-26) ### Bug Fixes * set hugr field of `PassResult` correctly ([#2715](#2715)) ([4abedab](4abedab)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 5, 2026
🤖 I have created a release *beep* *boop* --- ## [0.15.0](hugr-py-v0.14.2...hugr-py-v0.15.0) (2026-01-02) ### ⚠ BREAKING CHANGES * ValueArray is gone, as is LinearizeArrayPass * **hugr-py:** Removes `extensions` field of `val.Extension`. ### Features * `collated_digitstring_counts` to extend bitstring collation to digits ([#2788](#2788)) ([191c473](191c473)) * **hugr-py:** Remove `extensions` field of `val.Extension`. ([#2686](#2686)) ([911c089](911c089)) * Make `ComposablePass.__call__` return a Hugr ([#2697](#2697)) ([dbf8c8e](dbf8c8e)) * Result type for ComposablePasses ([#2703](#2703)) ([b8df28e](b8df28e)) ### Bug Fixes * **hugr-py:** solved graph rendering with `Const` nodes after applying`NormalizeGuppy` ([#2744](#2744)) ([d996690](d996690)) * set hugr field of `PassResult` correctly ([#2715](#2715)) ([d860722](d860722)) ### Code Refactoring * Delete ValueArray ([#2760](#2760)) ([b3cdc4e](b3cdc4e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.