feat(hugr-passes)!: normalize_cfgs inlines entry DFG by acl-cqc · Pull Request #2649 · Quantinuum/hugr

acl-cqc · 2025-10-28T15:48:26Z

Breaking followup to #2633.

normalize_cfgs moves the entry block outside the CFG even if there are outgoing Dom edges by inlining the DFG (so the entry block children become siblings of the CFG), as this makes said edges into valid Ext edges.

Sadly, I don't see a good/corresponding treatment for the exit dfg; it doesn't help that the source block of the Dom edges must dominate the exit (and hence we could break the CFG just before that source block and start another CFG), because even then there could be backedges to the source (new CFG entry) block, so we can't necessarily lift it outside. Options thus seem to be:

thread the values from the source block through the whole CFG
add extra outputs to the CFG, and thus to each predecessor of the new exit block - but that requires either finding the corresponding Tag, or also adding new inputs to any other successors of those predecessors (and any other predecessors of those, and so on)

...and I've not tried either of those here.

BREAKING CHANGE: NormalizeCFGResult specifies entry_nodes_moved not entry_dfg (as no DFG is inserted).

…cetype'd

…edges

codecov · 2025-10-28T15:54:25Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.46%. Comparing base (5e354b9) to head (94d2c75).
⚠️ Report is 16 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #2649   +/-   ##
=======================================
  Coverage   83.46%   83.46%           
=======================================
  Files         262      262           
  Lines       51297    51297           
  Branches    46858    46858           
=======================================
+ Hits        42813    42815    +2     
+ Misses       6105     6103    -2     
  Partials     2379     2379

Flag	Coverage Δ
python	`91.46% <ø> (ø)`
rust	`82.70% <100.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…entry

…ntry2

hugrbot · 2025-10-28T19:26:45Z

This PR contains breaking changes to the public Rust API.

cargo-semver-checks summary

    Building hugr v0.24.3 (current)
     Built [  18.801s] (current)
   Parsing hugr v0.24.3 (current)
    Parsed [   0.004s] (current)
  Building hugr v0.24.3 (baseline)
     Built [  17.646s] (baseline)
   Parsing hugr v0.24.3 (baseline)
    Parsed [   0.004s] (baseline)
  Checking hugr v0.24.3 -> v0.24.3 (assume minor change)
   Checked [   0.011s] 159 checks: 159 pass, 41 skip
   Summary no semver update required
  Finished [  37.727s] hugr
  Building hugr-cli v0.24.3 (current)
     Built [  17.360s] (current)
   Parsing hugr-cli v0.24.3 (current)
    Parsed [   0.008s] (current)
  Building hugr-cli v0.24.3 (baseline)
     Built [  16.255s] (baseline)
   Parsing hugr-cli v0.24.3 (baseline)
    Parsed [   0.009s] (baseline)
  Checking hugr-cli v0.24.3 -> v0.24.3 (assume minor change)
   Checked [   0.013s] 159 checks: 159 pass, 41 skip
   Summary no semver update required
  Finished [  36.261s] hugr-cli
  Building hugr-core v0.24.3 (current)
     Built [  13.631s] (current)
   Parsing hugr-core v0.24.3 (current)
    Parsed [   0.078s] (current)
  Building hugr-core v0.24.3 (baseline)
     Built [  13.592s] (baseline)
   Parsing hugr-core v0.24.3 (baseline)
    Parsed [   0.077s] (baseline)
  Checking hugr-core v0.24.3 -> v0.24.3 (assume minor change)
   Checked [   0.156s] 159 checks: 159 pass, 41 skip
   Summary no semver update required
  Finished [  29.314s] hugr-core
  Building hugr-llvm v0.24.3 (current)
     Built [  13.595s] (current)
   Parsing hugr-llvm v0.24.3 (current)
    Parsed [   0.011s] (current)
  Building hugr-llvm v0.24.3 (baseline)
     Built [  13.623s] (baseline)
   Parsing hugr-llvm v0.24.3 (baseline)
    Parsed [   0.010s] (baseline)
  Checking hugr-llvm v0.24.3 -> v0.24.3 (assume minor change)
   Checked [   0.031s] 159 checks: 159 pass, 41 skip
   Summary no semver update required
  Finished [  28.430s] hugr-llvm
  Building hugr-model v0.24.3 (current)
     Built [   4.683s] (current)
   Parsing hugr-model v0.24.3 (current)
    Parsed [   0.015s] (current)
  Building hugr-model v0.24.3 (baseline)
     Built [   4.619s] (baseline)
   Parsing hugr-model v0.24.3 (baseline)
    Parsed [   0.014s] (baseline)
  Checking hugr-model v0.24.3 -> v0.24.3 (assume minor change)
   Checked [   0.025s] 159 checks: 159 pass, 41 skip
   Summary no semver update required
  Finished [   9.999s] hugr-model
  Building hugr-passes v0.24.3 (current)
     Built [  13.456s] (current)
   Parsing hugr-passes v0.24.3 (current)
    Parsed [   0.024s] (current)
  Building hugr-passes v0.24.3 (baseline)
     Built [  13.456s] (baseline)
   Parsing hugr-passes v0.24.3 (baseline)
    Parsed [   0.023s] (baseline)
  Checking hugr-passes v0.24.3 -> v0.24.3 (assume minor change)
   Checked [   0.028s] 159 checks: 157 pass, 2 fail, 0 warn, 41 skip

--- failure enum_struct_variant_field_added: pub enum struct variant field added ---

Description:
An enum's exhaustive struct variant has a new field, which has to be included when constructing or matching on this variant.
      ref: https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_struct_variant_field_added.ron

Failed in:
field entry_nodes_moved of variant NormalizeCFGResult::CFGPreserved in /home/runner/work/hugr/hugr/PR_BRANCH/hugr-passes/src/normalize_cfgs.rs:89

--- failure enum_struct_variant_field_missing: pub enum struct variant's field removed or renamed ---

Description:
A publicly-visible enum has a struct variant whose field is no longer available under its prior name. It may have been renamed or removed entirely.
      ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
     impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_struct_variant_field_missing.ron

Failed in:
field entry_dfg of variant NormalizeCFGResult::CFGPreserved, previously in file /home/runner/work/hugr/hugr/BASELINE_BRANCH/hugr-passes/src/normalize_cfgs.rs:88

   Summary semver requires new major version: 2 major and 0 minor checks failed
  Finished [  27.990s] hugr-passes
  Building hugr-persistent v0.3.4 (current)
     Built [  10.680s] (current)
   Parsing hugr-persistent v0.3.4 (current)
    Parsed [   0.007s] (current)
  Building hugr-persistent v0.3.4 (baseline)
     Built [  10.627s] (baseline)
   Parsing hugr-persistent v0.3.4 (baseline)
    Parsed [   0.007s] (baseline)
  Checking hugr-persistent v0.3.4 -> v0.3.4 (assume minor change)
   Checked [   0.011s] 159 checks: 159 pass, 41 skip
   Summary no semver update required
  Finished [  22.350s] hugr-persistent

…entry2

acl-cqc · 2025-11-03T14:47:46Z

@croyzor I picked you because you were randomly picked for #2662 after Seyon had already stepped in, so remembering the lost roll of the dice ;)

croyzor · 2025-11-18T09:24:39Z

hugr-passes/src/normalize_cfgs.rs

+            },
+        );
+        let [_, entry_output] = h.get_io(entry).unwrap();
+        while let Some(n) = h.first_child(entry) {


wont this capture the input/output nodes?

Yes - we've built a DFG node, but not using the "builder", so it's completely empty; we transfer Input and Output nodes into it to make it valid. Then we do an InlineDFG, which removes them.

This release includes various breaking refactors and improvements: - A lot of work has been done towards linking Hugrs. Now module-rooted Hugrs can be linked together using configurable policies. - `ValueArray` has been removed. - A type-safe API for accessing metadata on nodes has been added. - Envelopes now have an extensive API for progressively describing a package, and failing gracefully on errors. - The MSRV has been bumped to Rust 1.89, and the public pyo3 dependency has been updated to 0.27. - Multiple deprecated definitions have been removed. ---- ## 🤖 New release * `hugr-model`: 0.24.3 -> 0.25.0 (✓ API compatible changes) * `hugr-core`: 0.24.3 -> 0.25.0 (⚠ API breaking changes) * `hugr-llvm`: 0.24.3 -> 0.25.0 (✓ API compatible changes) * `hugr-passes`: 0.24.3 -> 0.25.0 (⚠ API breaking changes) * `hugr-persistent`: 0.3.4 -> 0.4.0 (✓ API compatible changes) * `hugr`: 0.24.3 -> 0.25.0 (✓ API compatible changes) * `hugr-cli`: 0.24.3 -> 0.25.0 (⚠ API breaking changes) ### ⚠ `hugr-core` breaking changes ```text --- failure enum_marked_non_exhaustive: enum marked #[non_exhaustive] --- Description: A public enum has been marked #[non_exhaustive]. Pattern-matching on it outside of its crate must now include a wildcard pattern like `_`, or it will fail to compile. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_marked_non_exhaustive.ron Failed in: enum ReadError in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/envelope.rs:108 --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_missing.ron Failed in: enum hugr_core::envelope::EnvelopeError, previously in file /tmp/.tmpLNcYQE/hugr-core/src/envelope.rs:262 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/function_missing.ron Failed in: function hugr_core::std_extensions::collections::value_array::value_array_type, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:159 function hugr_core::envelope::format_generator, previously in file /tmp/.tmpLNcYQE/hugr-core/src/envelope.rs:93 function hugr_core::std_extensions::collections::value_array::value_array_type_def, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:150 function hugr_core::hugr::serialize::serde_deserialize_hugr, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/serialize.rs:180 function hugr_core::envelope::get_generator, previously in file /tmp/.tmpLNcYQE/hugr-core/src/envelope.rs:80 function hugr_core::std_extensions::collections::value_array::value_array_type_parametric, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:166 function hugr_core::std_extensions::collections::array::op_builder::build_all_value_array_ops, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/array/op_builder.rs:390 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/inherent_method_missing.ron Failed in: MermaidFormatter::from_render_config, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/views/render.rs:50 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/module_missing.ron Failed in: mod hugr_core::std_extensions::collections::value_array, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:1 --- failure pub_module_level_const_missing: pub module-level const is missing --- Description: A public const is missing or renamed ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/pub_module_level_const_missing.ron Failed in: USED_EXTENSIONS_KEY in file /tmp/.tmpLNcYQE/hugr-core/src/envelope.rs:72 VALUE_ARRAY_TYPENAME in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:27 VERSION in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:33 GENERATOR_KEY in file /tmp/.tmpLNcYQE/hugr-core/src/envelope.rs:70 EXTENSION_ID in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:31 VALUE_ARRAY_VALUENAME in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:29 --- failure pub_static_missing: pub static is missing --- Description: A public static is missing, renamed, or made private. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/pub_static_missing.ron Failed in: EXTENSION in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:99 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/struct_missing.ron Failed in: struct hugr_core::envelope::WithGenerator, previously in file /tmp/.tmpLNcYQE/hugr-core/src/envelope.rs:127 struct hugr_core::hugr::views::render::RenderConfig, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/views/render.rs:21 struct hugr_core::std_extensions::collections::value_array::ValueArray, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:39 --- failure trait_method_default_impl_removed: pub trait default method impl removed --- Description: A method's default impl in an unsealed trait has been removed, breaking trait implementations that relied on that default ref: https://doc.rust-lang.org/book/ch10-02-traits.html#default-implementations impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/trait_method_default_impl_removed.ron Failed in: trait method hugr_core::hugr::patch::PatchVerification::invalidated_nodes in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/patch.rs:45 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/trait_method_missing.ron Failed in: method invalidation_set of trait PatchVerification, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/patch.rs:44 method mermaid_string_with_config of trait HugrView, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/views.rs:404 method mermaid_string_with_config of trait HugrView, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/views.rs:404 method mermaid_string_with_config of trait HugrView, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/views.rs:404 method get_metadata_mut of trait HugrMut, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/hugrmut.rs:63 --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/trait_method_parameter_count_changed.ron Failed in: Container::set_metadata now takes 2 instead of 3 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/builder/build_traits.rs:114 Container::set_child_metadata now takes 3 instead of 4 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/builder/build_traits.rs:123 HugrView::get_metadata now takes 2 instead of 3 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/views.rs:107 HugrView::get_metadata now takes 2 instead of 3 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/views.rs:107 HugrView::get_metadata now takes 2 instead of 3 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/views.rs:107 HugrMut::set_metadata now takes 3 instead of 4 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/hugrmut.rs:79 HugrMut::remove_metadata now takes 2 instead of 3 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/hugrmut.rs:106 --- failure trait_method_requires_different_generic_type_params: trait method now requires a different number of generic type parameters --- Description: A trait method now requires a different number of generic type parameters than it used to. Calls or implementations of this trait method using the previous number of generic types will be broken. ref: https://doc.rust-lang.org/reference/items/generics.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/trait_method_requires_different_generic_type_params.ron Failed in: Container::set_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/builder/build_traits.rs:114 Container::set_child_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/builder/build_traits.rs:123 HugrView::get_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/views.rs:107 HugrView::get_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/views.rs:107 HugrView::get_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/views.rs:107 HugrMut::set_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/hugrmut.rs:79 HugrMut::remove_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/hugrmut.rs:106 --- failure trait_missing: pub trait removed or renamed --- Description: A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/trait_missing.ron Failed in: trait hugr_core::std_extensions::collections::value_array::VArrayOpBuilder, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:174 trait hugr_core::hugr::views::RootCheckable, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/views/root_checked.rs:73 ``` ### ⚠ `hugr-passes` breaking changes ```text --- failure enum_marked_non_exhaustive: enum marked #[non_exhaustive] --- Description: A public enum has been marked #[non_exhaustive]. Pattern-matching on it outside of its crate must now include a wildcard pattern like `_`, or it will fail to compile. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_marked_non_exhaustive.ron Failed in: enum NodeTemplate in /tmp/.tmpmZ0VmH/hugr/hugr-passes/src/replace_types.rs:40 --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_missing.ron Failed in: enum hugr_passes::call_graph::CallGraphNode, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/call_graph.rs:17 enum hugr_passes::call_graph::CallGraphEdge, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/call_graph.rs:9 --- failure enum_struct_variant_field_added: pub enum struct variant field added --- Description: An enum's exhaustive struct variant has a new field, which has to be included when constructing or matching on this variant. ref: https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_struct_variant_field_added.ron Failed in: field entry_nodes_moved of variant NormalizeCFGResult::CFGPreserved in /tmp/.tmpmZ0VmH/hugr/hugr-passes/src/normalize_cfgs.rs:89 --- failure enum_struct_variant_field_missing: pub enum struct variant's field removed or renamed --- Description: A publicly-visible enum has a struct variant whose field is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_struct_variant_field_missing.ron Failed in: field entry_dfg of variant NormalizeCFGResult::CFGPreserved, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/normalize_cfgs.rs:88 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/function_missing.ron Failed in: function hugr_passes::replace_types::handlers::linearize_value_array, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/replace_types/handlers.rs:298 function hugr_passes::merge_bbs::merge_basic_blocks, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/lib.rs:40 function hugr_passes::replace_types::handlers::value_array_const, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/replace_types/handlers.rs:97 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/module_missing.ron Failed in: mod hugr_passes::merge_bbs, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/lib.rs:26 mod hugr_passes::call_graph, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/call_graph.rs:1 mod hugr_passes::linearize_array, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/linearize_array.rs:1 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/struct_missing.ron Failed in: struct hugr_passes::call_graph::CallGraph, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/call_graph.rs:42 struct hugr_passes::linearize_array::LinearizeArrayPass, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/linearize_array.rs:35 struct hugr_passes::LinearizeArrayPass, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/linearize_array.rs:35 ``` ### ⚠ `hugr-cli` breaking changes ```text --- failure enum_variant_missing: pub enum variant removed or renamed --- Description: A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_variant_missing.ron Failed in: variant CliError::Envelope, previously in file /tmp/.tmpLNcYQE/hugr-cli/src/lib.rs:88 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/inherent_method_missing.ron Failed in: HugrInputArgs::get_envelope, previously in file /tmp/.tmpLNcYQE/hugr-cli/src/hugr_io.rs:63 HugrInputArgs::get_hugr, previously in file /tmp/.tmpLNcYQE/hugr-cli/src/hugr_io.rs:88 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/struct_pub_field_missing.ron Failed in: field hugr_json of struct HugrInputArgs, previously in file /tmp/.tmpLNcYQE/hugr-cli/src/hugr_io.rs:40 ``` <details><summary>Changelog</summary> ## `hugr-model` <blockquote> ## [0.25.0](hugr-model-v0.24.3...hugr-model-v0.25.0) - 2025-12-22 ### Bug Fixes - *(model)* avoid non abi-compatible pyo3 calls ([#2679](#2679)) ### New Features - [**breaking**] Upgrade pyo3 dependency to 0.27 ([#2736](#2736)) ### Refactor - Direct import of model representation to Python ([#2683](#2683)) </blockquote> ## `hugr-core` <blockquote> ## [0.25.0](hugr-core-v0.24.3...hugr-core-v0.25.0) - 2025-12-22 ### Bug Fixes - *(hugr-core)* [**breaking**] Return error instead of panicking in `MakeRegisteredOp::to_extension_op()` ([#2701](#2701)) - register packaged extensions before model_ast import ([#2702](#2702)) - ModuleGraph misses static edges to non-container entrypoints ([#2745](#2745)) ### New Features - return description output to python on error ([#2681](#2681)) - add hugr-core StaticGraph, deprecate hugr-passes CallGraph ([#2698](#2698)) - [**breaking**] Remove `RootCheckable` ([#2704](#2704)) - Add method to link Hugr modules (linking pt3) ([#2529](#2529)) - `insert_link_hugr` adds entrypoint subtree and links, with reachability ([#2555](#2555)) - [**breaking**] Upgrade pyo3 dependency to 0.27 ([#2736](#2736)) - [**breaking**] Bump MSRV to Rust 1.89 ([#2747](#2747)) - [**breaking**] Allow disconnecting specific edges in a hugr ([#2737](#2737)) - Optype iterators over value ports ([#2738](#2738)) - [**breaking**] Type-safe access for node metadata ([#2755](#2755)) - [**breaking**] GeneratorDesc metadata definition ([#2759](#2759)) ### Refactor - [**breaking**] move envelope reading to dedicated module with dedicated errors ([#2689](#2689)) - Direct import of model representation to Python ([#2683](#2683)) - *(linking.rs)* [**breaking**] (tiny) avoid type_complexity ([#2721](#2721)) - [**breaking**] Remove multiple deprecated definitions ([#2751](#2751)) - [**breaking**] Delete ValueArray ([#2760](#2760)) - Deprecate Value::Function and inline_constant_functions ([#2770](#2770)) </blockquote> ## `hugr-llvm` <blockquote> ## [0.25.0](hugr-llvm-v0.24.3...hugr-llvm-v0.25.0) - 2025-12-22 ### New Features - *(llvm)* [**breaking**] upgrade to inkwell 0.7 ([#2695](#2695)) ### Refactor - Deprecate Value::Function and inline_constant_functions ([#2770](#2770)) </blockquote> ## `hugr-passes` <blockquote> ## [0.25.0](hugr-passes-v0.24.3...hugr-passes-v0.25.0) - 2025-12-22 ### New Features - *(hugr-passes)* [**breaking**] normalize_cfgs inlines entry DFG ([#2649](#2649)) - add hugr-core StaticGraph, deprecate hugr-passes CallGraph ([#2698](#2698)) - ReplaceTypes: recurse on replacements, much deprecation ([#2442](#2442)) - [**breaking**] Remove `RootCheckable` ([#2704](#2704)) - [**breaking**] Bump MSRV to Rust 1.89 ([#2747](#2747)) - Add a pass to remove redundant order edges ([#2739](#2739)) - *(hugr-passes)* [**breaking**] add NodeTemplate::LinkedHugr, deprecate ::Call ([#2749](#2749)) ### Refactor - [**breaking**] Remove multiple deprecated definitions ([#2751](#2751)) - [**breaking**] Delete ValueArray ([#2760](#2760)) - Deprecate Value::Function and inline_constant_functions ([#2770](#2770)) ### Testing - Make Hugr valid in replace_types::op_to_call ([#2732](#2732)) </blockquote> ## `hugr-persistent` <blockquote> ## [0.4.0](hugr-persistent-v0.3.4...hugr-persistent-v0.4.0) - 2025-12-22 ### New Features - [**breaking**] Remove `RootCheckable` ([#2704](#2704)) - [**breaking**] Bump MSRV to Rust 1.89 ([#2747](#2747)) - [**breaking**] Type-safe access for node metadata ([#2755](#2755)) ### Refactor - [**breaking**] Remove multiple deprecated definitions ([#2751](#2751)) </blockquote> ## `hugr` <blockquote> ## [0.25.0](hugr-v0.24.3...hugr-v0.25.0) - 2025-12-22 ### Bug Fixes - *(hugr-core)* [**breaking**] Return error instead of panicking in `MakeRegisteredOp::to_extension_op()` ([#2701](#2701)) - register packaged extensions before model_ast import ([#2702](#2702)) - ModuleGraph misses static edges to non-container entrypoints ([#2745](#2745)) ### Documentation - Improve instructions for patch release ([#2720](#2720)) ### New Features - *(hugr-passes)* [**breaking**] normalize_cfgs inlines entry DFG ([#2649](#2649)) - ReplaceTypes: recurse on replacements, much deprecation ([#2442](#2442)) - Add a pass to remove redundant order edges ([#2739](#2739)) - *(hugr-passes)* [**breaking**] add NodeTemplate::LinkedHugr, deprecate ::Call ([#2749](#2749)) - return description output to python on error ([#2681](#2681)) - add hugr-core StaticGraph, deprecate hugr-passes CallGraph ([#2698](#2698)) - [**breaking**] Remove `RootCheckable` ([#2704](#2704)) - Add method to link Hugr modules (linking pt3) ([#2529](#2529)) - `insert_link_hugr` adds entrypoint subtree and links, with reachability ([#2555](#2555)) - [**breaking**] Upgrade pyo3 dependency to 0.27 ([#2736](#2736)) - [**breaking**] Bump MSRV to Rust 1.89 ([#2747](#2747)) - [**breaking**] Allow disconnecting specific edges in a hugr ([#2737](#2737)) - Optype iterators over value ports ([#2738](#2738)) - [**breaking**] GeneratorDesc metadata definition ([#2759](#2759)) - [**breaking**] Type-safe access for node metadata ([#2755](#2755)) ### Refactor - [**breaking**] move envelope reading to dedicated module with dedicated errors ([#2689](#2689)) - Direct import of model representation to Python ([#2683](#2683)) - *(linking.rs)* [**breaking**] (tiny) avoid type_complexity ([#2721](#2721)) - [**breaking**] Remove multiple deprecated definitions ([#2751](#2751)) - [**breaking**] Delete ValueArray ([#2760](#2760)) - Deprecate Value::Function and inline_constant_functions ([#2770](#2770)) ### Testing - Make Hugr valid in replace_types::op_to_call ([#2732](#2732)) </blockquote> ## `hugr-cli` <blockquote> ## [0.25.0](hugr-cli-v0.24.3...hugr-cli-v0.25.0) - 2025-12-22 ### New Features - *(cli, python)* programmatic interface to cli with python bindings ([#2677](#2677)) - return description output to python on error ([#2681](#2681)) - [**breaking**] Type-safe access for node metadata ([#2755](#2755)) - [**breaking**] GeneratorDesc metadata definition ([#2759](#2759)) ### Refactor - [**breaking**] move envelope reading to dedicated module with dedicated errors ([#2689](#2689)) - *(cli)* [**breaking**] remove deprecated hugr_json handling ([#2690](#2690)) - [**breaking**] Remove multiple deprecated definitions ([#2751](#2751)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: Agustín Borgna <[email protected]>

acl-cqc added 9 commits October 23, 2025 11:34

Fix validation...breaking tests

2c647ca

Fix ReplaceTypes tests - Function containing DFG entrypoint not repla…

15b92f7

…cetype'd

normalize_cfgs: handle nonlocal edges from Entry. TODO into exit-pred...

d087d4d

fix test

0d048e2

Outline exit predecessor only if no op inside has nonlocal inputs

485adbd

don't panic if there are ext edges into exit-predecessor

0908342

Convert entry to DFG or leave alone if outgoing nonlocals

483b4ba

ReplaceTypes tests back to DFGBuilder - ReplaceTypes whole Hugr

4b0adc8

Inline entry-block (reporting nodes moved), thus preserving nonlocal …

b2167bb

…edges

acl-cqc changed the title ~~feat!(hugr-passes): ReplaceTypes on whole Hugr, normalize_cfgs inlines entry DFG~~ feat(hugr-passes)!: ReplaceTypes on whole Hugr, normalize_cfgs inlines entry DFG Oct 28, 2025

acl-cqc mentioned this pull request Oct 28, 2025

fix: validation outside entrypoint, normalize_cfgs w/ nonlocal edges #2633

Merged

acl-cqc added 2 commits October 28, 2025 18:16

clarify checks

7cdd73c

and more

51ea7cf

Base automatically changed from acl/validate_outside_entry to main October 28, 2025 18:50

acl-cqc added 4 commits October 28, 2025 19:04

Merge remote-tracking branch 'origin/main' into acl/validate_outside_…

f0a483b

…entry

Merge branch 'acl/validate_outside_entry' into acl/validate_outside_e…

936e7b8

…ntry2

Retain parametrized rstest

7c05bf7

fmt

6385937

acl-cqc marked this pull request as ready for review October 28, 2025 20:18

acl-cqc requested a review from a team as a code owner October 28, 2025 20:18

acl-cqc requested a review from lmondada October 28, 2025 20:18

acl-cqc added 2 commits November 3, 2025 13:09

doc

982ddd2

Merge remote-tracking branch 'origin/main' into acl/validate_outside_…

54e39dd

…entry2

acl-cqc changed the title ~~feat(hugr-passes)!: ReplaceTypes on whole Hugr, normalize_cfgs inlines entry DFG~~ feat(hugr-passes)!: normalize_cfgs inlines entry DFG Nov 3, 2025

acl-cqc requested review from croyzor and removed request for lmondada November 3, 2025 14:47

Merge branch 'main' into acl/validate_outside_entry2

94d2c75

croyzor reviewed Nov 18, 2025

View reviewed changes

croyzor approved these changes Nov 18, 2025

View reviewed changes

aborgna-q added this to the hugr-rs 0.25.0 milestone Nov 18, 2025

aborgna-q added the S-breaking-change Status: Need a breaking change release to progress label Nov 18, 2025

acl-cqc added this pull request to the merge queue Nov 18, 2025

Merged via the queue into main with commit cad2f55 Nov 18, 2025
32 checks passed

acl-cqc deleted the acl/validate_outside_entry2 branch November 18, 2025 17:56

hugrbot mentioned this pull request Nov 18, 2025

chore: release #2674

Merged

hugrbot mentioned this pull request Dec 23, 2025

chore: release #2778

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(hugr-passes)!: normalize_cfgs inlines entry DFG#2649

feat(hugr-passes)!: normalize_cfgs inlines entry DFG#2649
acl-cqc merged 18 commits intomainfrom
acl/validate_outside_entry2

acl-cqc commented Oct 28, 2025 •

edited

Loading

Uh oh!

codecov bot commented Oct 28, 2025 •

edited

Loading

Uh oh!

hugrbot commented Oct 28, 2025 •

edited

Loading

Uh oh!

acl-cqc commented Nov 3, 2025

Uh oh!

croyzor Nov 18, 2025

Uh oh!

acl-cqc Nov 18, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

acl-cqc commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

hugrbot commented Oct 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

acl-cqc commented Nov 3, 2025

Uh oh!

croyzor Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

acl-cqc Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

acl-cqc commented Oct 28, 2025 •

edited

Loading

codecov bot commented Oct 28, 2025 •

edited

Loading

hugrbot commented Oct 28, 2025 •

edited

Loading