feat: Add method to link Hugr modules (linking pt3) by acl-cqc · Pull Request #2529 · Quantinuum/hugr

acl-cqc · 2025-08-25T11:33:19Z

closes #2356, adding new methods link_module and link_module_view.

These ignore the entrypoint.
But take a 'policy' that acts on names of public functions to determine how to link the two Hugrs.

Does not use callgraph/reachability; this is coming in #2555.

There are a few other suggestions for even further into the future in #2687.

…r/from_view

…ink_nodes

…ing NOTESTS

This reverts commit caecc43.

Copilot

Pull Request Overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 4 comments.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

hugr-core/src/hugr/linking.rs

Copilot · 2025-11-17T13:28:33Z

hugr-core/src/hugr/linking.rs

+            let Some((mut acc, sig1)) = acc else {
+                return Some((new.map_right(|n| (n, vec![])), sig2));
+            };
+            assert_eq!(sig1, sig2, "Invalid Hugr: different signatures for {name}");


The error message 'Invalid Hugr: different signatures for {name}' should use :? formatting for the name variable to ensure proper display. Change to \"Invalid Hugr: different signatures for {name:?}\".

Suggested change

assert_eq!(sig1, sig2, "Invalid Hugr: different signatures for {name}");

assert_eq!(sig1, sig2, "Invalid Hugr: different signatures for {name:?}");

Copilot · 2025-11-17T13:28:33Z

hugr-core/src/hugr/linking.rs

+                    true => "Multiple FuncDefns",
+                    false => "FuncDefn and FuncDecl(s)",
+                };
+                panic!("Invalid Hugr: {err} for {name}");


The panic message should use :? formatting for the name variable. Change to panic!(\"Invalid Hugr: {err} for {name:?}\");.

Suggested change

panic!("Invalid Hugr: {err} for {name}");

panic!("Invalid Hugr: {err} for {name:?}");

hugr-core/src/hugr/linking.rs

acl-cqc · 2025-11-17T22:05:52Z

hugr-core/src/hugr/linking.rs

+
+    #[rstest]
+    fn combines_decls_defn(
+        #[values(OnNewFunc::RaiseError, OnNewFunc::Add)] sig_conflict: OnNewFunc,


This mass of #[values....] is because none of these actually matter, the test is the same in all cases...

I'd like to define a pytest-like "parametrized fixture" #[fixture] fn any_policy(#[values....] ....) -> NameLinkingPolicy and then have every test using any_policy get run multiple times, but rstest doesn't offer such a facility. There are crates that do: https://crates.io/crates/rstest_reuse (a small addition) and https://crates.io/crates/rustest (a complete replacement of rstest)....

doug-q

Looks Great!

Just nits.

doug-q · 2025-11-24T11:12:00Z

hugr-core/src/hugr/linking.rs

    }
 }

+/// Describes ways to link a "Source" Hugr being inserted into a target Hugr.


NIT this seems inconsistent, i would choose from source target and "Source" "Target"

Took me a moment to grok that one....lol, love it, will do

doug-q · 2025-11-24T11:13:05Z

hugr-core/src/hugr/linking.rs

+///
+/// [FuncDefn]: crate::ops::FuncDefn
+/// [Visibility::Public]: crate::Visibility::Public


Suggested change

///

/// [FuncDefn]: crate::ops::FuncDefn

/// [Visibility::Public]: crate::Visibility::Public

doug-q · 2025-11-24T11:14:36Z

hugr-core/src/hugr/linking.rs

+/// [Visibility::Public]: crate::Visibility::Public
+#[derive(Copy, Clone, Debug, Hash, PartialEq, Eq, derive_more::From)]
+#[non_exhaustive] // could consider e.g. disconnections
+pub enum OnMultiDefn {


I think this could also apply to FuncDecls.

?? If their names and sigs are the same, we can just merge them, they are identical (aliases) - of course we cannot merge impls (ok, we could check same nodes in same order, build a map between the indices, and then check the edges matched...even that is quite a bit of work and would miss reorderings of nodes, which brings us to graph isomorphism).

Or do you mean, so you can control whether aliases are combined vs kept separate?

I was thinking about controlling when they are combined vs kept separate.
But this is fine as is

The other way to look at it is that switching between impls of the same-name-and-signature FuncDefn doesn't invalidate the Hugr, whereas other changes invalidate....?

doug-q · 2025-11-24T11:16:55Z

hugr-core/src/hugr/linking.rs

+    /// Computes how this policy will act on a specified source (inserted) and target
+    /// (host) Hugr.
+    #[allow(clippy::type_complexity)]
+    pub fn to_node_linking<T: HugrView + ?Sized, S: HugrView>(


Not a big fan of to_node_linking. It makes me think that we are converting into a NodeLinking, which isn't a thing. What about link_actions

doug-q · 2025-11-24T11:17:42Z

hugr-core/src/hugr/linking.rs

+    ///
+    /// [Visibility::Public]: crate::Visibility::Public
+    /// [FuncDefn]: crate::ops::FuncDefn
+    fn link_module(


I think we should be explicit that entrypoint is ignored

hugr-core/src/hugr/linking.rs

doug-q · 2025-11-24T11:21:27Z

hugr-core/src/hugr/linking.rs

+/// Details the concrete actions to link a specific source Hugr into a specific target Hugr.
+///
+/// Computed from a [NameLinkingPolicy] and contains all actions required to implement
+/// that policy (for those specific Hugrs).


Suggested change

/// that policy (for those specific Hugrs).

/// that policy for those specific Hugrs.

doug-q · 2025-11-24T11:21:44Z

hugr-core/src/hugr/linking.rs

+///
+/// Computed from a [NameLinkingPolicy] and contains all actions required to implement
+/// that policy (for those specific Hugrs).
+pub type LinkActions<SN, TN> = HashMap<SN, LinkAction<TN>>;


Can we use BTreeMap so that determinism is never an issue?

I've switched this one to BTreeMap because it's externally visible and so you might print it. The ordering should not affect the result of linking (unless you hand-construct a map of actions which modify each other or something), so I've not switched any of the other HashMaps....

I would prefer to use BTreeMap everywhere.
When we have determinism bugs we will grep for Hash everywhere.

…nvalid

…hability (#2555) * Add `insert_link_hugr` and `insert_link_view` taking a node under which to add the entrypoint * Add reachability analysis, used for private functions, and for public functions when using the new `insert_link_xxx` * This is a change in behaviour from earlier #2529 but no release has been made in the interim so not breaking * Extend NameLinkingPolicy to allow setting how to handle to new names in the source Hugr closes #2517

This release includes various breaking refactors and improvements: - A lot of work has been done towards linking Hugrs. Now module-rooted Hugrs can be linked together using configurable policies. - `ValueArray` has been removed. - A type-safe API for accessing metadata on nodes has been added. - Envelopes now have an extensive API for progressively describing a package, and failing gracefully on errors. - The MSRV has been bumped to Rust 1.89, and the public pyo3 dependency has been updated to 0.27. - Multiple deprecated definitions have been removed. ---- ## 🤖 New release * `hugr-model`: 0.24.3 -> 0.25.0 (✓ API compatible changes) * `hugr-core`: 0.24.3 -> 0.25.0 (⚠ API breaking changes) * `hugr-llvm`: 0.24.3 -> 0.25.0 (✓ API compatible changes) * `hugr-passes`: 0.24.3 -> 0.25.0 (⚠ API breaking changes) * `hugr-persistent`: 0.3.4 -> 0.4.0 (✓ API compatible changes) * `hugr`: 0.24.3 -> 0.25.0 (✓ API compatible changes) * `hugr-cli`: 0.24.3 -> 0.25.0 (⚠ API breaking changes) ### ⚠ `hugr-core` breaking changes ```text --- failure enum_marked_non_exhaustive: enum marked #[non_exhaustive] --- Description: A public enum has been marked #[non_exhaustive]. Pattern-matching on it outside of its crate must now include a wildcard pattern like `_`, or it will fail to compile. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_marked_non_exhaustive.ron Failed in: enum ReadError in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/envelope.rs:108 --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_missing.ron Failed in: enum hugr_core::envelope::EnvelopeError, previously in file /tmp/.tmpLNcYQE/hugr-core/src/envelope.rs:262 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/function_missing.ron Failed in: function hugr_core::std_extensions::collections::value_array::value_array_type, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:159 function hugr_core::envelope::format_generator, previously in file /tmp/.tmpLNcYQE/hugr-core/src/envelope.rs:93 function hugr_core::std_extensions::collections::value_array::value_array_type_def, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:150 function hugr_core::hugr::serialize::serde_deserialize_hugr, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/serialize.rs:180 function hugr_core::envelope::get_generator, previously in file /tmp/.tmpLNcYQE/hugr-core/src/envelope.rs:80 function hugr_core::std_extensions::collections::value_array::value_array_type_parametric, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:166 function hugr_core::std_extensions::collections::array::op_builder::build_all_value_array_ops, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/array/op_builder.rs:390 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/inherent_method_missing.ron Failed in: MermaidFormatter::from_render_config, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/views/render.rs:50 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/module_missing.ron Failed in: mod hugr_core::std_extensions::collections::value_array, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:1 --- failure pub_module_level_const_missing: pub module-level const is missing --- Description: A public const is missing or renamed ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/pub_module_level_const_missing.ron Failed in: USED_EXTENSIONS_KEY in file /tmp/.tmpLNcYQE/hugr-core/src/envelope.rs:72 VALUE_ARRAY_TYPENAME in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:27 VERSION in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:33 GENERATOR_KEY in file /tmp/.tmpLNcYQE/hugr-core/src/envelope.rs:70 EXTENSION_ID in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:31 VALUE_ARRAY_VALUENAME in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:29 --- failure pub_static_missing: pub static is missing --- Description: A public static is missing, renamed, or made private. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/pub_static_missing.ron Failed in: EXTENSION in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:99 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/struct_missing.ron Failed in: struct hugr_core::envelope::WithGenerator, previously in file /tmp/.tmpLNcYQE/hugr-core/src/envelope.rs:127 struct hugr_core::hugr::views::render::RenderConfig, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/views/render.rs:21 struct hugr_core::std_extensions::collections::value_array::ValueArray, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:39 --- failure trait_method_default_impl_removed: pub trait default method impl removed --- Description: A method's default impl in an unsealed trait has been removed, breaking trait implementations that relied on that default ref: https://doc.rust-lang.org/book/ch10-02-traits.html#default-implementations impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/trait_method_default_impl_removed.ron Failed in: trait method hugr_core::hugr::patch::PatchVerification::invalidated_nodes in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/patch.rs:45 --- failure trait_method_missing: pub trait method removed or renamed --- Description: A trait method is no longer callable, and may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/trait_method_missing.ron Failed in: method invalidation_set of trait PatchVerification, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/patch.rs:44 method mermaid_string_with_config of trait HugrView, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/views.rs:404 method mermaid_string_with_config of trait HugrView, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/views.rs:404 method mermaid_string_with_config of trait HugrView, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/views.rs:404 method get_metadata_mut of trait HugrMut, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/hugrmut.rs:63 --- failure trait_method_parameter_count_changed: pub trait method parameter count changed --- Description: A trait method now takes a different number of parameters. ref: https://doc.rust-lang.org/cargo/reference/semver.html#major-any-change-to-trait-item-signatures impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/trait_method_parameter_count_changed.ron Failed in: Container::set_metadata now takes 2 instead of 3 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/builder/build_traits.rs:114 Container::set_child_metadata now takes 3 instead of 4 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/builder/build_traits.rs:123 HugrView::get_metadata now takes 2 instead of 3 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/views.rs:107 HugrView::get_metadata now takes 2 instead of 3 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/views.rs:107 HugrView::get_metadata now takes 2 instead of 3 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/views.rs:107 HugrMut::set_metadata now takes 3 instead of 4 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/hugrmut.rs:79 HugrMut::remove_metadata now takes 2 instead of 3 parameters, in file /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/hugrmut.rs:106 --- failure trait_method_requires_different_generic_type_params: trait method now requires a different number of generic type parameters --- Description: A trait method now requires a different number of generic type parameters than it used to. Calls or implementations of this trait method using the previous number of generic types will be broken. ref: https://doc.rust-lang.org/reference/items/generics.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/trait_method_requires_different_generic_type_params.ron Failed in: Container::set_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/builder/build_traits.rs:114 Container::set_child_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/builder/build_traits.rs:123 HugrView::get_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/views.rs:107 HugrView::get_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/views.rs:107 HugrView::get_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/views.rs:107 HugrMut::set_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/hugrmut.rs:79 HugrMut::remove_metadata (0 -> 1 generic types) in /tmp/.tmpmZ0VmH/hugr/hugr-core/src/hugr/hugrmut.rs:106 --- failure trait_missing: pub trait removed or renamed --- Description: A publicly-visible trait cannot be imported by its prior path. A `pub use` may have been removed, or the trait itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/trait_missing.ron Failed in: trait hugr_core::std_extensions::collections::value_array::VArrayOpBuilder, previously in file /tmp/.tmpLNcYQE/hugr-core/src/std_extensions/collections/value_array.rs:174 trait hugr_core::hugr::views::RootCheckable, previously in file /tmp/.tmpLNcYQE/hugr-core/src/hugr/views/root_checked.rs:73 ``` ### ⚠ `hugr-passes` breaking changes ```text --- failure enum_marked_non_exhaustive: enum marked #[non_exhaustive] --- Description: A public enum has been marked #[non_exhaustive]. Pattern-matching on it outside of its crate must now include a wildcard pattern like `_`, or it will fail to compile. ref: https://doc.rust-lang.org/cargo/reference/semver.html#attr-adding-non-exhaustive impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_marked_non_exhaustive.ron Failed in: enum NodeTemplate in /tmp/.tmpmZ0VmH/hugr/hugr-passes/src/replace_types.rs:40 --- failure enum_missing: pub enum removed or renamed --- Description: A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_missing.ron Failed in: enum hugr_passes::call_graph::CallGraphNode, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/call_graph.rs:17 enum hugr_passes::call_graph::CallGraphEdge, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/call_graph.rs:9 --- failure enum_struct_variant_field_added: pub enum struct variant field added --- Description: An enum's exhaustive struct variant has a new field, which has to be included when constructing or matching on this variant. ref: https://doc.rust-lang.org/reference/attributes/type_system.html#the-non_exhaustive-attribute impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_struct_variant_field_added.ron Failed in: field entry_nodes_moved of variant NormalizeCFGResult::CFGPreserved in /tmp/.tmpmZ0VmH/hugr/hugr-passes/src/normalize_cfgs.rs:89 --- failure enum_struct_variant_field_missing: pub enum struct variant's field removed or renamed --- Description: A publicly-visible enum has a struct variant whose field is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_struct_variant_field_missing.ron Failed in: field entry_dfg of variant NormalizeCFGResult::CFGPreserved, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/normalize_cfgs.rs:88 --- failure function_missing: pub fn removed or renamed --- Description: A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/function_missing.ron Failed in: function hugr_passes::replace_types::handlers::linearize_value_array, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/replace_types/handlers.rs:298 function hugr_passes::merge_bbs::merge_basic_blocks, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/lib.rs:40 function hugr_passes::replace_types::handlers::value_array_const, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/replace_types/handlers.rs:97 --- failure module_missing: pub module removed or renamed --- Description: A publicly-visible module cannot be imported by its prior path. A `pub use` may have been removed, or the module may have been renamed, removed, or made non-public. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/module_missing.ron Failed in: mod hugr_passes::merge_bbs, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/lib.rs:26 mod hugr_passes::call_graph, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/call_graph.rs:1 mod hugr_passes::linearize_array, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/linearize_array.rs:1 --- failure struct_missing: pub struct removed or renamed --- Description: A publicly-visible struct cannot be imported by its prior path. A `pub use` may have been removed, or the struct itself may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/struct_missing.ron Failed in: struct hugr_passes::call_graph::CallGraph, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/call_graph.rs:42 struct hugr_passes::linearize_array::LinearizeArrayPass, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/linearize_array.rs:35 struct hugr_passes::LinearizeArrayPass, previously in file /tmp/.tmpLNcYQE/hugr-passes/src/linearize_array.rs:35 ``` ### ⚠ `hugr-cli` breaking changes ```text --- failure enum_variant_missing: pub enum variant removed or renamed --- Description: A publicly-visible enum has at least one variant that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/enum_variant_missing.ron Failed in: variant CliError::Envelope, previously in file /tmp/.tmpLNcYQE/hugr-cli/src/lib.rs:88 --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/inherent_method_missing.ron Failed in: HugrInputArgs::get_envelope, previously in file /tmp/.tmpLNcYQE/hugr-cli/src/hugr_io.rs:63 HugrInputArgs::get_hugr, previously in file /tmp/.tmpLNcYQE/hugr-cli/src/hugr_io.rs:88 --- failure struct_pub_field_missing: pub struct's pub field removed or renamed --- Description: A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.45.0/src/lints/struct_pub_field_missing.ron Failed in: field hugr_json of struct HugrInputArgs, previously in file /tmp/.tmpLNcYQE/hugr-cli/src/hugr_io.rs:40 ``` <details><summary>Changelog</summary> ## `hugr-model` <blockquote> ## [0.25.0](hugr-model-v0.24.3...hugr-model-v0.25.0) - 2025-12-22 ### Bug Fixes - *(model)* avoid non abi-compatible pyo3 calls ([#2679](#2679)) ### New Features - [**breaking**] Upgrade pyo3 dependency to 0.27 ([#2736](#2736)) ### Refactor - Direct import of model representation to Python ([#2683](#2683)) </blockquote> ## `hugr-core` <blockquote> ## [0.25.0](hugr-core-v0.24.3...hugr-core-v0.25.0) - 2025-12-22 ### Bug Fixes - *(hugr-core)* [**breaking**] Return error instead of panicking in `MakeRegisteredOp::to_extension_op()` ([#2701](#2701)) - register packaged extensions before model_ast import ([#2702](#2702)) - ModuleGraph misses static edges to non-container entrypoints ([#2745](#2745)) ### New Features - return description output to python on error ([#2681](#2681)) - add hugr-core StaticGraph, deprecate hugr-passes CallGraph ([#2698](#2698)) - [**breaking**] Remove `RootCheckable` ([#2704](#2704)) - Add method to link Hugr modules (linking pt3) ([#2529](#2529)) - `insert_link_hugr` adds entrypoint subtree and links, with reachability ([#2555](#2555)) - [**breaking**] Upgrade pyo3 dependency to 0.27 ([#2736](#2736)) - [**breaking**] Bump MSRV to Rust 1.89 ([#2747](#2747)) - [**breaking**] Allow disconnecting specific edges in a hugr ([#2737](#2737)) - Optype iterators over value ports ([#2738](#2738)) - [**breaking**] Type-safe access for node metadata ([#2755](#2755)) - [**breaking**] GeneratorDesc metadata definition ([#2759](#2759)) ### Refactor - [**breaking**] move envelope reading to dedicated module with dedicated errors ([#2689](#2689)) - Direct import of model representation to Python ([#2683](#2683)) - *(linking.rs)* [**breaking**] (tiny) avoid type_complexity ([#2721](#2721)) - [**breaking**] Remove multiple deprecated definitions ([#2751](#2751)) - [**breaking**] Delete ValueArray ([#2760](#2760)) - Deprecate Value::Function and inline_constant_functions ([#2770](#2770)) </blockquote> ## `hugr-llvm` <blockquote> ## [0.25.0](hugr-llvm-v0.24.3...hugr-llvm-v0.25.0) - 2025-12-22 ### New Features - *(llvm)* [**breaking**] upgrade to inkwell 0.7 ([#2695](#2695)) ### Refactor - Deprecate Value::Function and inline_constant_functions ([#2770](#2770)) </blockquote> ## `hugr-passes` <blockquote> ## [0.25.0](hugr-passes-v0.24.3...hugr-passes-v0.25.0) - 2025-12-22 ### New Features - *(hugr-passes)* [**breaking**] normalize_cfgs inlines entry DFG ([#2649](#2649)) - add hugr-core StaticGraph, deprecate hugr-passes CallGraph ([#2698](#2698)) - ReplaceTypes: recurse on replacements, much deprecation ([#2442](#2442)) - [**breaking**] Remove `RootCheckable` ([#2704](#2704)) - [**breaking**] Bump MSRV to Rust 1.89 ([#2747](#2747)) - Add a pass to remove redundant order edges ([#2739](#2739)) - *(hugr-passes)* [**breaking**] add NodeTemplate::LinkedHugr, deprecate ::Call ([#2749](#2749)) ### Refactor - [**breaking**] Remove multiple deprecated definitions ([#2751](#2751)) - [**breaking**] Delete ValueArray ([#2760](#2760)) - Deprecate Value::Function and inline_constant_functions ([#2770](#2770)) ### Testing - Make Hugr valid in replace_types::op_to_call ([#2732](#2732)) </blockquote> ## `hugr-persistent` <blockquote> ## [0.4.0](hugr-persistent-v0.3.4...hugr-persistent-v0.4.0) - 2025-12-22 ### New Features - [**breaking**] Remove `RootCheckable` ([#2704](#2704)) - [**breaking**] Bump MSRV to Rust 1.89 ([#2747](#2747)) - [**breaking**] Type-safe access for node metadata ([#2755](#2755)) ### Refactor - [**breaking**] Remove multiple deprecated definitions ([#2751](#2751)) </blockquote> ## `hugr` <blockquote> ## [0.25.0](hugr-v0.24.3...hugr-v0.25.0) - 2025-12-22 ### Bug Fixes - *(hugr-core)* [**breaking**] Return error instead of panicking in `MakeRegisteredOp::to_extension_op()` ([#2701](#2701)) - register packaged extensions before model_ast import ([#2702](#2702)) - ModuleGraph misses static edges to non-container entrypoints ([#2745](#2745)) ### Documentation - Improve instructions for patch release ([#2720](#2720)) ### New Features - *(hugr-passes)* [**breaking**] normalize_cfgs inlines entry DFG ([#2649](#2649)) - ReplaceTypes: recurse on replacements, much deprecation ([#2442](#2442)) - Add a pass to remove redundant order edges ([#2739](#2739)) - *(hugr-passes)* [**breaking**] add NodeTemplate::LinkedHugr, deprecate ::Call ([#2749](#2749)) - return description output to python on error ([#2681](#2681)) - add hugr-core StaticGraph, deprecate hugr-passes CallGraph ([#2698](#2698)) - [**breaking**] Remove `RootCheckable` ([#2704](#2704)) - Add method to link Hugr modules (linking pt3) ([#2529](#2529)) - `insert_link_hugr` adds entrypoint subtree and links, with reachability ([#2555](#2555)) - [**breaking**] Upgrade pyo3 dependency to 0.27 ([#2736](#2736)) - [**breaking**] Bump MSRV to Rust 1.89 ([#2747](#2747)) - [**breaking**] Allow disconnecting specific edges in a hugr ([#2737](#2737)) - Optype iterators over value ports ([#2738](#2738)) - [**breaking**] GeneratorDesc metadata definition ([#2759](#2759)) - [**breaking**] Type-safe access for node metadata ([#2755](#2755)) ### Refactor - [**breaking**] move envelope reading to dedicated module with dedicated errors ([#2689](#2689)) - Direct import of model representation to Python ([#2683](#2683)) - *(linking.rs)* [**breaking**] (tiny) avoid type_complexity ([#2721](#2721)) - [**breaking**] Remove multiple deprecated definitions ([#2751](#2751)) - [**breaking**] Delete ValueArray ([#2760](#2760)) - Deprecate Value::Function and inline_constant_functions ([#2770](#2770)) ### Testing - Make Hugr valid in replace_types::op_to_call ([#2732](#2732)) </blockquote> ## `hugr-cli` <blockquote> ## [0.25.0](hugr-cli-v0.24.3...hugr-cli-v0.25.0) - 2025-12-22 ### New Features - *(cli, python)* programmatic interface to cli with python bindings ([#2677](#2677)) - return description output to python on error ([#2681](#2681)) - [**breaking**] Type-safe access for node metadata ([#2755](#2755)) - [**breaking**] GeneratorDesc metadata definition ([#2759](#2759)) ### Refactor - [**breaking**] move envelope reading to dedicated module with dedicated errors ([#2689](#2689)) - *(cli)* [**breaking**] remove deprecated hugr_json handling ([#2690](#2690)) - [**breaking**] Remove multiple deprecated definitions ([#2751](#2751)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: Agustín Borgna <[email protected]>

## 🤖 New release * `hugr-model`: 0.25.0 -> 0.25.1 (✓ API compatible changes) * `hugr-core`: 0.25.0 -> 0.25.1 (✓ API compatible changes) * `hugr-llvm`: 0.25.0 -> 0.25.1 (✓ API compatible changes) * `hugr-passes`: 0.25.0 -> 0.25.1 (✓ API compatible changes) * `hugr-persistent`: 0.4.0 -> 0.4.1 (✓ API compatible changes) * `hugr`: 0.25.0 -> 0.25.1 (✓ API compatible changes) * `hugr-cli`: 0.25.0 -> 0.25.1 <details><summary>Changelog</summary> ## `hugr-model` <blockquote> ## [0.25.0](hugr-model-v0.24.3...hugr-model-v0.25.0) - 2025-12-22 ### Bug Fixes - *(model)* avoid non abi-compatible pyo3 calls ([#2679](#2679)) ### New Features - [**breaking**] Upgrade pyo3 dependency to 0.27 ([#2736](#2736)) ### Refactor - Direct import of model representation to Python ([#2683](#2683)) </blockquote> ## `hugr-core` <blockquote> ## [0.25.0](hugr-core-v0.24.3...hugr-core-v0.25.0) - 2025-12-22 ### Bug Fixes - *(hugr-core)* [**breaking**] Return error instead of panicking in `MakeRegisteredOp::to_extension_op()` ([#2701](#2701)) - register packaged extensions before model_ast import ([#2702](#2702)) - ModuleGraph misses static edges to non-container entrypoints ([#2745](#2745)) ### New Features - return description output to python on error ([#2681](#2681)) - add hugr-core StaticGraph, deprecate hugr-passes CallGraph ([#2698](#2698)) - [**breaking**] Remove `RootCheckable` ([#2704](#2704)) - Add method to link Hugr modules (linking pt3) ([#2529](#2529)) - `insert_link_hugr` adds entrypoint subtree and links, with reachability ([#2555](#2555)) - [**breaking**] Upgrade pyo3 dependency to 0.27 ([#2736](#2736)) - [**breaking**] Bump MSRV to Rust 1.89 ([#2747](#2747)) - [**breaking**] Allow disconnecting specific edges in a hugr ([#2737](#2737)) - Optype iterators over value ports ([#2738](#2738)) - [**breaking**] Type-safe access for node metadata ([#2755](#2755)) - [**breaking**] GeneratorDesc metadata definition ([#2759](#2759)) ### Refactor - [**breaking**] move envelope reading to dedicated module with dedicated errors ([#2689](#2689)) - Direct import of model representation to Python ([#2683](#2683)) - *(linking.rs)* [**breaking**] (tiny) avoid type_complexity ([#2721](#2721)) - [**breaking**] Remove multiple deprecated definitions ([#2751](#2751)) - [**breaking**] Delete ValueArray ([#2760](#2760)) - Deprecate Value::Function and inline_constant_functions ([#2770](#2770)) </blockquote> ## `hugr-llvm` <blockquote> ## [0.25.0](hugr-llvm-v0.24.3...hugr-llvm-v0.25.0) - 2025-12-22 ### New Features - *(llvm)* [**breaking**] upgrade to inkwell 0.7 ([#2695](#2695)) ### Refactor - Deprecate Value::Function and inline_constant_functions ([#2770](#2770)) </blockquote> ## `hugr-passes` <blockquote> ## [0.25.1](hugr-passes-v0.25.0...hugr-passes-v0.25.1) - 2025-12-29 ### Bug Fixes - two problems in array linearization from #2749 ([#2779](#2779)) </blockquote> ## `hugr-persistent` <blockquote> ## [0.4.0](hugr-persistent-v0.3.4...hugr-persistent-v0.4.0) - 2025-12-22 ### New Features - [**breaking**] Remove `RootCheckable` ([#2704](#2704)) - [**breaking**] Bump MSRV to Rust 1.89 ([#2747](#2747)) - [**breaking**] Type-safe access for node metadata ([#2755](#2755)) ### Refactor - [**breaking**] Remove multiple deprecated definitions ([#2751](#2751)) </blockquote> ## `hugr` <blockquote> ## [0.25.1](hugr-v0.25.0...hugr-v0.25.1) - 2025-12-29 ### Bug Fixes - two problems in array linearization from #2749 ([#2779](#2779)) </blockquote> ## `hugr-cli` <blockquote> ## [0.25.0](hugr-cli-v0.24.3...hugr-cli-v0.25.0) - 2025-12-22 ### New Features - *(cli, python)* programmatic interface to cli with python bindings ([#2677](#2677)) - return description output to python on error ([#2681](#2681)) - [**breaking**] Type-safe access for node metadata ([#2755](#2755)) - [**breaking**] GeneratorDesc metadata definition ([#2759](#2759)) ### Refactor - [**breaking**] move envelope reading to dedicated module with dedicated errors ([#2689](#2689)) - *(cli)* [**breaking**] remove deprecated hugr_json handling ([#2690](#2690)) - [**breaking**] Remove multiple deprecated definitions ([#2751](#2751)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/).

acl-cqc added 30 commits August 11, 2025 13:28

Add HugrMut::insert_forest / insert_view_forest, implement insert_hug…

1723b48

…r/from_view

insert_subgraph delegates to insert_forest (copying nodes list)

2e66542

errors; docs

02fea73

Tests

fdee944

fix test - edges removed rather than delocalized

0eaf3eb

Merge remote-tracking branch 'origin/main' into acl/insert_forest

05072b6

More docs/links

f55c288

WIP

3621a7f

Dedup dfg_calling_defn_decl, start

0f3883b

Implement LinkHugr, split old insert_link_nodes -> check_directives+l…

865fdb8

…ink_nodes

Fix test, and note duplication

54e87a0

Common up insertion-checking in tests; expand doc

b522ff1

fix doclinks

5774665

Error on overlapping Add::replace; handle Add overlapping w/ UseExist…

7c41f73

…ing NOTESTS

test multi-replace / replace+add

e70015f

fix doc

7001f9c

NodeLinkingDirective::replace takes impl IntoIterator

698283c

Avoid test nondeterminism; clippy

18e1cf7

Add NameLinkingPolicy+friends, and LinkHugr::link_hugr

5e0cf33

Remove copy_private_funcs; fix test to expect main

c210f28

Accessor/factory methods (need docs), enum SignatureConflictHandling

68a1ca6

Optimize by turning HashMap into impl IntoIterator, avoid size_hint

10778ce

struct InsertedForest; use InsertForestResult alias more widely

826990d

N -> SN

f9eee44

Make DoubleCopy contain a named field

caecc43

Revert "Make DoubleCopy contain a named field"

bd12196

This reverts commit caecc43.

Use rstest::fixture

bdc0ff1

test tidy

58dccdd

add benchmark

b1c0d2a

lint benchmark and add to criterion group

88a4987

acl-cqc requested a review from Copilot November 17, 2025 13:27

Copilot AI reviewed Nov 17, 2025

View reviewed changes

acl-cqc added 5 commits November 17, 2025 13:31

copilot assert

4b5730e

More copilot: &String -> &str

203923b

Correct comment implement->link *1

3f5f925

Tidy let-else+panic into match+2*panic

d45db9d

Rename impl->defn accessors + MultipleImpls->Defn error variant

fd6ad94

acl-cqc commented Nov 17, 2025

View reviewed changes

acl-cqc added 2 commits November 21, 2025 19:34

Merge remote-tracking branch 'origin/main' into acl/link_hugr

da2efb3

NameLinkingError is non_exhaustive

7925437

doug-q approved these changes Nov 24, 2025

View reviewed changes

acl-cqc added 2 commits November 24, 2025 21:01

comments+renames from review

0bd5147

Use BTreeMap for LinkActions

8a58970

acl-cqc added the wait to merge label Nov 25, 2025

Remove 3* type_complexity, sort some imports

c0102f2

acl-cqc added this to the hugr-rs 0.25.0 milestone Nov 30, 2025

acl-cqc added 3 commits December 2, 2025 17:57

rename get_(=>on_)signature_conflict, improve accessor docs

cebe07a

Rename OnMultiDefn::Use(Existing/New) => Use(Target/Source)

525f9d0

Remove NameLinkingPolicy::err_on_conflict; rename (=>new_)keep_both_i…

9f502df

…nvalid

acl-cqc changed the title ~~feat: Add method to link Hugr modules (linking pt3 of >=4)~~ feat: Add method to link Hugr modules (linking pt3) Dec 9, 2025

acl-cqc enabled auto-merge December 9, 2025 19:29

acl-cqc added this pull request to the merge queue Dec 9, 2025

Merged via the queue into main with commit 194173e Dec 9, 2025
32 checks passed

acl-cqc deleted the acl/link_hugr branch December 9, 2025 19:41

hugrbot mentioned this pull request Dec 9, 2025

chore: release #2674

Merged

hugrbot mentioned this pull request Dec 23, 2025

chore: release #2778

Merged

	assert_eq!(sig1, sig2, "Invalid Hugr: different signatures for {name}");
	assert_eq!(sig1, sig2, "Invalid Hugr: different signatures for {name:?}");

	panic!("Invalid Hugr: {err} for {name}");
	panic!("Invalid Hugr: {err} for {name:?}");

	///
	/// [FuncDefn]: crate::ops::FuncDefn
	/// [Visibility::Public]: crate::Visibility::Public

	/// that policy (for those specific Hugrs).
	/// that policy for those specific Hugrs.

Conversation

acl-cqc commented Aug 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Uh oh!

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

doug-q left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

acl-cqc Nov 24, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

acl-cqc commented Aug 25, 2025 •

edited

Loading

doug-q left a comment •

edited

Loading

acl-cqc Nov 24, 2025 •

edited

Loading