Adding visualization to uarray expressions#75
Merged
saulshanabrook merged 1 commit intoQuansight-Labs:masterfrom Dec 8, 2018
Merged
Adding visualization to uarray expressions#75saulshanabrook merged 1 commit intoQuansight-Labs:masterfrom
saulshanabrook merged 1 commit intoQuansight-Labs:masterfrom
Conversation
costrouc
force-pushed
the
visualize-matchpy-expressions
branch
from
7226586 to
630676a
Compare
Contributor
Author
|
Need to add a notebook to demonstrate visualization. |
costrouc
force-pushed
the
visualize-matchpy-expressions
branch
from
630676a to
c819133
Compare
saulshanabrook
approved these changes
Dec 7, 2018
Contributor
saulshanabrook
left a comment
saulshanabrook
left a comment
There was a problem hiding this comment.
Looks good! Yep having a notebook would be nice, I am excited to see how this looks for real expressions!
costrouc
force-pushed
the
visualize-matchpy-expressions
branch
from
c819133 to
7d58088
Compare
Contributor
Author
|
Notebook now exists to demonstrate. Here is a screenshot of visualizing
So both views are possible. I think that the first is more helpful for viewing reductions. @saulshanabrook if this is good with you I will merge. I know that I can merge anytime but for now I would like to ask for approval first. |
Notebook `Uarray Visualization.ipynb` included to demonstrate with expressions.
costrouc
force-pushed
the
visualize-matchpy-expressions
branch
from
7d58088 to
e126dfe
Compare
Contributor
|
Looks great! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like
matchpydoes not want to upstream visualization which is understandable. HPAC/matchpy#48For now this PR adds a function
visualize_expressionwhich will return a graphviz object that will easily render in jupyter notebooks. This PR will require additional work in that we would like to add a notebook demonstrating the visualizations.Action is needed on which Symbols/Objects in uarray to give the
_repr_gviz_node_to which will allow for gviz visualization. For now it has a default representation for Symbols/Operations.Closes #40