This repository was archived by the owner on Aug 21, 2023. It is now read-only.
fix missing backticks for plot_histogram()#1480
Merged
Eric-Arellano merged 7 commits intoQiskit:masterfrom Jul 27, 2023
Merged
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Eric-Arellano
suggested changes
Jul 11, 2023
Collaborator
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
Hi, thanks for this improvement! We appreciate you making Qiskit better :)
It looks like this commit changes 1153 lines, when we want it to only change 1 line. In looking at the commit locally with Git, it looks like ^M is being added to every single line. I'm not sure why, but possibly from your text editor? What text editor / IDE are you using?
To fix this, you can use git revert 1feebb9 to revert your changes, and then have a new commit that only changes the 1 single line. Make sure before committing that the diff only has one line changed.
Eric-Arellano
previously approved these changes
Jul 27, 2023
Eric-Arellano
approved these changes
Jul 27, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The function plot_histogram() in the text should be
plot_histogram()Details and comments