This repository was archived by the owner on Aug 21, 2023. It is now read-only.
Small fixes of 1_getting_started_with_qiskit.ipynb#1383
Merged
mergify[bot] merged 2 commits intoQiskit:masterfrom Jan 12, 2023
Merged
Small fixes of 1_getting_started_with_qiskit.ipynb#1383mergify[bot] merged 2 commits intoQiskit:masterfrom
mergify[bot] merged 2 commits intoQiskit:masterfrom
Conversation
Small fixes of the tutorial 1_getting_started_with_qiskit: - "`execute` function" --> "`run` method" in the text (in the code cells was already correct) - "addition operator" --> "compose method" in a comment of a code cell - there was some backtick too much, so the fix is: "``" --> "`" (for example, ``job`` --> `job`)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
arne-kapell
approved these changes
Dec 25, 2022
arne-kapell
left a comment
arne-kapell
left a comment
There was a problem hiding this comment.
only the described small fixes, nothing is changed code-wise
(I noticed the mistakes too, so I went looking for an already opened PR)
HuangJunye
approved these changes
Jan 12, 2023
Contributor
HuangJunye
left a comment
HuangJunye
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the fix!
Contributor
|
@arne-kapell Thanks for the review as well. Your efforts are appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Small fixes of the tutorial 1_getting_started_with_qiskit:
executefunction" --> "runmethod" in the text (in the code cells was already correct)" --> "`" (for example,job`` -->job)Details and comments
see above