Skip to content
This repository was archived by the owner on Aug 21, 2023. It is now read-only.

Typo and duplications in 04_transpiler_passes_and_passmanager.ipynb#1239

Closed
qu-tan-um wants to merge 5 commits intoQiskit:masterfrom
qu-tan-um:master
Closed

Typo and duplications in 04_transpiler_passes_and_passmanager.ipynb#1239
qu-tan-um wants to merge 5 commits intoQiskit:masterfrom
qu-tan-um:master

Conversation

@qu-tan-um
Copy link
Copy Markdown
Contributor

Summary

Correcting typo and duplications in 04_transpiler_passes_and_passmanager.ipynb
The detail to each individual correction is in its commit title and comment.

Details and comments

Since the next line gets `dag.op_nodes()[3]`
The `draw` method of `Circuit` is drawing twice in Jupyter notebooks: once from mpl plotting, and once from displaying the returned object. A fix for this is a local variable named `fig` for example. Then, only the mpl plotting is displayed.
Since `circuits = [log_circ, log_circ]`
@review-notebook-app
Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Eric-Arellano
Copy link
Copy Markdown
Collaborator

I couldn't push to your branch, so closing in favor of #1494. Thanks for making Qiskit better! Pardon the delay in review also.

Eric-Arellano added a commit that referenced this pull request Aug 21, 2023
Built on top of #1239.

---------

Co-authored-by: Bochen "Daniel" Tan <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants