This repository was archived by the owner on Aug 19, 2023. It is now read-only.
Add benchmarks for bind_parameters#896
Merged
nonhermitian merged 7 commits intoQiskit:masterfrom Apr 25, 2020
Merged
Conversation
This commit adds a synthetic benchmark for running bind_parameters on a parameterized circuit. It is basically a dual of the circuit construction benchmark except that it adds a sweep on the number of parameters.
kdk
approved these changes
Apr 23, 2020
Member
kdk
left a comment
kdk
left a comment
There was a problem hiding this comment.
This looks good. If we have the the runtime, a nice addition would be a benchmark timing bind_parameters over a circuit containing composite instructions (to trigger QuantumCircuit._rebind_definition), which would be closer to the aqua use-case, and likely quite a bit slower.
Member
Author
|
We probably will have the runtime after Qiskit/qiskit#4227 and Qiskit/qiskit#4232 merge. Prior to that though the parameterized circuit construction time will take too long. With 0.13.0 the run time of these benchmarks locally with |
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 1, 2023
* Add benchmarks for bind_parameters This commit adds a synthetic benchmark for running bind_parameters on a parameterized circuit. It is basically a dual of the circuit construction benchmark except that it adds a sweep on the number of parameters. * Reduce number of permutations * Add parameterized construction bench and fix lint Co-authored-by: Paul Nation <[email protected]> Co-authored-by: Jay Gambetta <[email protected]>
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
* Add benchmarks for bind_parameters This commit adds a synthetic benchmark for running bind_parameters on a parameterized circuit. It is basically a dual of the circuit construction benchmark except that it adds a sweep on the number of parameters. * Reduce number of permutations * Add parameterized construction bench and fix lint Co-authored-by: Paul Nation <[email protected]> Co-authored-by: Jay Gambetta <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds a synthetic benchmark for running bind_parameters on a
parameterized circuit. It is basically a dual of the circuit
construction benchmark except that it adds a sweep on the number of
parameters.
Details and comments