This repository was archived by the owner on Aug 19, 2023. It is now read-only.
Add disassemble benchmarks and more permutations to assemble#846
Merged
kdk merged 4 commits intoQiskit:masterfrom Mar 17, 2020
Merged
Conversation
This commit expands our coverage of the assemble benchmarks by adding assembly cases with >1 circuit. At the same time this adds a second benchmark class which adds coverage for qobj disassemble.
kdk
reviewed
Mar 16, 2020
Member
kdk
left a comment
kdk
left a comment
There was a problem hiding this comment.
Looks good, one lint failure, one question.
Co-Authored-By: Kevin Krsulich <[email protected]>
kdk
approved these changes
Mar 17, 2020
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 1, 2023
…qiskit-metapackage#846) * Add disassemble benchmarks and more permutations to assemble This commit expands our coverage of the assemble benchmarks by adding assembly cases with >1 circuit. At the same time this adds a second benchmark class which adds coverage for qobj disassemble. * Update test/benchmarks/assembler.py Co-Authored-By: Kevin Krsulich <[email protected]> * Add new version to assembler benchmark Co-authored-by: Kevin Krsulich <[email protected]> Co-authored-by: Kevin Krsulich <[email protected]>
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
…qiskit-metapackage#846) * Add disassemble benchmarks and more permutations to assemble This commit expands our coverage of the assemble benchmarks by adding assembly cases with >1 circuit. At the same time this adds a second benchmark class which adds coverage for qobj disassemble. * Update test/benchmarks/assembler.py Co-Authored-By: Kevin Krsulich <[email protected]> * Add new version to assembler benchmark Co-authored-by: Kevin Krsulich <[email protected]> Co-authored-by: Kevin Krsulich <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit expands our coverage of the assemble benchmarks by adding
assembly cases with >1 circuit. At the same time this adds a second
benchmark class which adds coverage for qobj disassemble.
Details and comments