This repository was archived by the owner on Aug 19, 2023. It is now read-only.
Update state tomography benchmarks to use ignis#400
Merged
jaygambetta merged 12 commits intoQiskit:masterfrom Aug 13, 2019
Merged
Update state tomography benchmarks to use ignis#400jaygambetta merged 12 commits intoQiskit:masterfrom
jaygambetta merged 12 commits intoQiskit:masterfrom
Conversation
The state tomography benchmarks have been skipped since terra deprecated and then removed it's support for doing tomography. The new way to run tomography is by using ignis. This commit does just that and rewrites the tomography benchmarks to use ignis instead of terra so that we can now run them on the current versions of terra.
jaygambetta
previously approved these changes
Aug 13, 2019
The cat state tomography benchmark for 5 qubits typically takes about 55 seconds for my local desktop. However, sometimes it can take slightly longer and with a default timeout of 60 seconds it doesn't give much of a margin.
The 6 qubit cat state tomography benchmark is a bit too slow to be valuable. On my local desktop it's consistently more than the current timeout of the state tomography benchmark which is 2min (the bell state tomography does not have an duration issues, it's minimally slower with 6 qubits). We already have a ton of very slow benchmarks and the additional value for running tomography with 6 qubits vs 5 is minimal. So in the interest of time this commit removes the 6 qubit cases.
jaygambetta
approved these changes
Aug 13, 2019
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 1, 2023
…ckage#400) * Update state tomography benchmarks to use ignis The state tomography benchmarks have been skipped since terra deprecated and then removed it's support for doing tomography. The new way to run tomography is by using ignis. This commit does just that and rewrites the tomography benchmarks to use ignis instead of terra so that we can now run them on the current versions of terra. * Fix lint * Add a 6 qubit benchmark * Fix lint again * Remove setting timer it's already the default * Increase timeout for state tomography benchmarks The cat state tomography benchmark for 5 qubits typically takes about 55 seconds for my local desktop. However, sometimes it can take slightly longer and with a default timeout of 60 seconds it doesn't give much of a margin. * Remove 6 qubit benchmark The 6 qubit cat state tomography benchmark is a bit too slow to be valuable. On my local desktop it's consistently more than the current timeout of the state tomography benchmark which is 2min (the bell state tomography does not have an duration issues, it's minimally slower with 6 qubits). We already have a ton of very slow benchmarks and the additional value for running tomography with 6 qubits vs 5 is minimal. So in the interest of time this commit removes the 6 qubit cases. * Fix lint yet again
jakelishman
pushed a commit
to jakelishman/qiskit-terra
that referenced
this pull request
Aug 11, 2023
…ckage#400) * Update state tomography benchmarks to use ignis The state tomography benchmarks have been skipped since terra deprecated and then removed it's support for doing tomography. The new way to run tomography is by using ignis. This commit does just that and rewrites the tomography benchmarks to use ignis instead of terra so that we can now run them on the current versions of terra. * Fix lint * Add a 6 qubit benchmark * Fix lint again * Remove setting timer it's already the default * Increase timeout for state tomography benchmarks The cat state tomography benchmark for 5 qubits typically takes about 55 seconds for my local desktop. However, sometimes it can take slightly longer and with a default timeout of 60 seconds it doesn't give much of a margin. * Remove 6 qubit benchmark The 6 qubit cat state tomography benchmark is a bit too slow to be valuable. On my local desktop it's consistently more than the current timeout of the state tomography benchmark which is 2min (the bell state tomography does not have an duration issues, it's minimally slower with 6 qubits). We already have a ton of very slow benchmarks and the additional value for running tomography with 6 qubits vs 5 is minimal. So in the interest of time this commit removes the 6 qubit cases. * Fix lint yet again
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The state tomography benchmarks have been skipped since terra deprecated
and then removed it's support for doing tomography. The new way to run
tomography is by using ignis. This commit does just that and rewrites
the tomography benchmarks to use ignis instead of terra so that we can
now run them on the current versions of terra.
Details and comments