Migrate visualization to top level namespace#1878
Merged
ajavadia merged 11 commits intoQiskit:masterfrom Apr 4, 2019
Merged
Conversation
mtreinish
requested review from
1ucian0,
ajavadia,
atilag,
delapuente,
diego-plan9,
ewinston,
jaygambetta,
kdk,
nonhermitian and
taalexander
as code owners
mtreinish
force-pushed
the
migrate-visualization
branch
from
513e646 to
4a708a7
Compare
Member
|
while moving these files should we also remove the leading underscores? (#1206) |
ajavadia
reviewed
Mar 10, 2019
ajavadia
requested changes
Mar 10, 2019
Member
ajavadia
left a comment
ajavadia
left a comment
There was a problem hiding this comment.
should also move the test files from test.python.tools.visualization up one level.
Member
|
yes I think we should |
mtreinish
force-pushed
the
migrate-visualization
branch
from
9e9b4ca to
644159e
Compare
mtreinish
force-pushed
the
migrate-visualization
branch
from
0356b83 to
6439a65
Compare
Member
|
@mtreinish can you also remove the leading underscore from the files here as you move them? |
mtreinish
force-pushed
the
migrate-visualization
branch
from
5ef9fab to
cad4291
Compare
ajavadia
previously approved these changes
Apr 4, 2019
This commit moves the visualization code out of tools into it's own top level namespace, 'qiskit.visualization'. The visualization was a bit out of place in the tools directory and is really it's own top level thing at this point. However, because we declared the public visualization interfaces stable as part of the 0.7 release we must maintain backwards compatibility. In order to facilitate that all the public APIs are still accessible via 'qiskit.tools.visualization'. However, private api/modules are not accessible off of 'qiskit.tools.visualization' anymore.
mtreinish
force-pushed
the
migrate-visualization
branch
from
6174659 to
5956b21
Compare
ajavadia
approved these changes
Apr 4, 2019
lia-approves
pushed a commit
to edasgupta/qiskit-terra
that referenced
this pull request
Jul 30, 2019
* Migrate visualization to top level namespace This commit moves the visualization code out of tools into it's own top level namespace, 'qiskit.visualization'. The visualization was a bit out of place in the tools directory and is really it's own top level thing at this point. However, because we declared the public visualization interfaces stable as part of the 0.7 release we must maintain backwards compatibility. In order to facilitate that all the public APIs are still accessible via 'qiskit.tools.visualization'. However, private api/modules are not accessible off of 'qiskit.tools.visualization' anymore. * Add changelog * Fix lint Sigh pylint, raising an error for both using a wildcard import and not using all the imports from the wild card. * Rebase updates * Move tests to match new dir structure * Update test_visualization import per review comment * Remove underscores from visualization modules * Fix lint
Merged
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This commit moves the visualization code out of tools into it's own top
level namespace,
qiskit.visualization. The visualization was a bit outof place in the tools directory and is really it's own top level thing
at this point. However, because we declared the public visualization
interfaces stable as part of the 0.7 release we must maintain backwards
compatibility. In order to facilitate that all the public APIs are still
accessible via
qiskit.tools.visualization. However, privateapi/modules are not accessible off of
qiskit.tools.visualizationanymore.
Details and comments