Skip to content

Set up infrastructure for qiskit-tutorials migration (backport #10443)#10625

Merged
mtreinish merged 1 commit intostable/0.25from
mergify/bp/stable/0.25/pr-10443
Aug 14, 2023
Merged

Set up infrastructure for qiskit-tutorials migration (backport #10443)#10625
mtreinish merged 1 commit intostable/0.25from
mergify/bp/stable/0.25/pr-10443

Conversation

@mergify
Copy link
Copy Markdown
Contributor

@mergify mergify Bot commented Aug 14, 2023

This is an automatic backport of pull request #10443 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

* Add infrastructure for building tutorials

This first commit is a rebase of Eric's initial PR as of db1ce62 onto
`main`, fixing up some changes caused by the CI infrastructure changing
a bit since the PR was first opened.

Co-authored-by: Jake Lishman <[email protected]>

* Harden tutorials Azure job

This moves much of the fetch- and process-related code into separate
scripts that assert far more about the directory structure, and fail if
they do not match the assumptions.  We don't want to accidentally get
out-of-sync while we're changing things and end up with a tutorials job
that isn't really doing its job without us noticing.

The tutorials-fetching script can now also be re-used in a separate
GitHub Actions workflow that will handle the full tutorials-included
documentation build and deployment in the future.

The notebook-convertion step is moved into Python space, using
`nbconvert` as a library in order to parallelise the build process for
the tutorials, and to allow CI and developers calling `tox` directly to
specify the output directories for the built tutorials.

* Retarget tutorial-conversion utility as executor

This reorganises the tutorial "conversion" utility to make it clearer
that what it's actually doing is just executing the tutorials.  The
script itself is changed to default to editing the files inplace, while
the `tox` job is updated to write the files into a special directory,
making it easier to clean up a dirty build directory and making it so
subsequent local executions will not pick up the converted files.

* Allow configuration of tutorials execution

There was a worry that not being able to configure these would make it
more unpleasant to use `tox` for the jobs locally.

---------

Co-authored-by: Jake Lishman <[email protected]>
(cherry picked from commit df2ddca)
@mergify mergify Bot requested review from a team, ElePT and woodsp-ibm as code owners August 14, 2023 19:41
@qiskit-bot
Copy link
Copy Markdown
Collaborator

Thank you for opening a new pull request.

Before your PR can be merged it will first need to pass continuous integration tests and be reviewed. Sometimes the review process can be slow, so please be patient.

While you're waiting, please feel free to review other open PRs. While only a subset of people are authorized to approve pull requests for merging, everyone is encouraged to review open pull requests. Doing reviews helps reduce the burden on the core team and helps make the project's code better for everyone.

One or more of the the following people are requested to review this:

@mtreinish mtreinish enabled auto-merge August 14, 2023 19:42
@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 5859936279

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.005%) to 87.242%

Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/lex.rs 2 90.89%
crates/qasm2/src/parse.rs 6 97.13%
Totals Coverage Status
Change from base Build 5826442592: -0.005%
Covered Lines: 74082
Relevant Lines: 84916

💛 - Coveralls

@mtreinish mtreinish added this pull request to the merge queue Aug 14, 2023
Merged via the queue into stable/0.25 with commit 3d22ba1 Aug 14, 2023
@mergify mergify Bot deleted the mergify/bp/stable/0.25/pr-10443 branch August 14, 2023 22:20
@mtreinish mtreinish added the Changelog: None Do not include in the GitHub Release changelog. label Aug 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Changelog: None Do not include in the GitHub Release changelog.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants