Skip to content

Remove deprecated BIPMapping pass#10526

Merged
jakelishman merged 6 commits intoQiskit:mainfrom
mtreinish:remove-bip
Sep 12, 2023
Merged

Remove deprecated BIPMapping pass#10526
jakelishman merged 6 commits intoQiskit:mainfrom
mtreinish:remove-bip

Conversation

@mtreinish
Copy link
Copy Markdown
Member

@mtreinish mtreinish commented Jul 28, 2023

Summary

This commit removes the deprecated BIPMapping pass. It was deprecated in qiskit-terra 0.24.0 and the minimum deprecation period has elapsed for the Qiskit 0.45.0 release. This pass has been moved to an external plugin that can be installed separately and integrated into the transpiler more cleanly than a single pass and also separates the optional dependency on the proprietary CPLEX into a separate package.

Details and comments

@mtreinish mtreinish added the Changelog: Removed Add a "Removed" entry in the GitHub Release changelog. label Jul 28, 2023
@mtreinish mtreinish added this to the 0.45.0 milestone Jul 28, 2023
@mtreinish mtreinish requested review from a team, ElePT and woodsp-ibm as code owners July 28, 2023 14:50
@qiskit-bot
Copy link
Copy Markdown
Collaborator

qiskit-bot commented Jul 28, 2023

One or more of the the following people are requested to review this:

  • @ElePT
  • @Qiskit/terra-core
  • @woodsp-ibm

kevinhartman
kevinhartman reviewed Jul 28, 2023
View reviewed changes
Comment thread releasenotes/notes/remove-deprecated-bip-mapper-e1206c8f905502dd.yaml Outdated
Comment thread releasenotes/notes/remove-deprecated-bip-mapper-e1206c8f905502dd.yaml Outdated
@mtreinish mtreinish mentioned this pull request Aug 10, 2023
Merged
mtreinish and others added 2 commits September 11, 2023 16:44
@mtreinish
Remove deprecated BIPMapping pass
e4257dc 
This commit removes the deprecated BIPMapping pass. It was deprecated in
qiskit-terra 0.24.0 and the minimum deprecation period has elapsed for
the Qiskit 0.45.0 release. This pass has been moved to an external
plugin that can be installed separately and integrated into the
transpiler more cleanly than a single pass and also separates the
optional dependency on the proprietary CPLEX into a separate package.
@mtreinish @kevinhartman
Apply suggestions from code review
960912d 
Co-authored-by: Kevin Hartman <[email protected]>
@mtreinish
Remove additional uses of BIPMapping
88aef1e 
There were still two locations where the BIPMapping pass was being used.
First the dedicated unit tests, and then also import redirects for the
docs and easier access. This commit removes these locations so nothing
left is using the BIPMapping pass.
@coveralls
Copy link
Copy Markdown

coveralls commented Sep 11, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6160673765

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 12 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.03%) to 87.239%
Files with Coverage Reduction New Missed Lines %
crates/qasm2/src/expr.rs 1 93.76%
qiskit/quantum_info/synthesis/two_qubit_decompose.py 2 96.65%
crates/qasm2/src/lex.rs 3 90.91%
crates/qasm2/src/parse.rs 6 96.67%
Totals Coverage Status
Change from base Build 6160358090: -0.03%
Covered Lines: 74147
Relevant Lines: 84993
💛 - Coveralls

jakelishman
jakelishman reviewed Sep 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the docs and install hints around HAS_CPLEX and HAS_DOCPLEX to comment that they're no longer used by Qiskit, and update their install hints to remove the reference to the (already) non-existent extra bip-mapper?

@mtreinish
Copy link
Copy Markdown
Member Author

mtreinish commented Sep 12, 2023

I updated the docs in: 83a0d28

@jakelishman
Copy link
Copy Markdown
Member

jakelishman commented Sep 12, 2023

There's also the install='pip install qiskit-terra[bip-mapper]' lines in the actual definitions of those two objects (lines 249 and 255 of qiskit/utils/optionals.py) if you want to get those in this PR. It's pre-existing though (the optional was removed already), so we can get it in a follow-up if you prefer.

@mtreinish
Copy link
Copy Markdown
Member Author

mtreinish commented Sep 12, 2023

I updated them in: 2a72879 it makes sense to do it here even if it was pre-existing. I felt a bit odd about the cplex one though, because pip install cplex is installing a "free" demo version that is very limited. The real way to install cplex is to buy it from IBM and install the full package which includes the python extension without limitations.

jakelishman
jakelishman approved these changes Sep 12, 2023
View reviewed changes
Copy link
Copy Markdown
Member

@jakelishman jakelishman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, the CPLEX situation was always a bit of a problem, which is in part why we've walked the path that's led us to this PR overall haha.

The actual install command in the checkers isn't really going to matter because nobody will see it any more, but at least now it's not obviously incorrect.

@jakelishman jakelishman added this pull request to the merge queue Sep 12, 2023
Merged via the queue into Qiskit:main with commit 2ab1e54 Sep 12, 2023
@mtreinish mtreinish deleted the remove-bip branch October 10, 2023 21:27
mtreinish added a commit to mtreinish/qiskit-core that referenced this pull request Dec 3, 2023
@mtreinish
Remove unused optional requirements
611c7ce 
With the removal of algorithms and opflow in Qiskit#11324, Qiskit#11111, and Qiskit#11086
along with the removal of the BIPMapping transpiler pass in Qiskit#10526
several optional test dependencies are no longer used in the code base.
This commit removes them from requirements-optional.txt as several have
compatibility issues with Python 3.12 and are causing failures in the
nightly builds. Since they're no longer used we shouldn't bother
installing them anymore.
@mtreinish mtreinish mentioned this pull request Dec 3, 2023
Merged
github-merge-queue Bot pushed a commit that referenced this pull request Dec 3, 2023
@mtreinish
Remove unused optional requirements (#11364)
6137248 
With the removal of algorithms and opflow in #11324, #11111, and #11086
along with the removal of the BIPMapping transpiler pass in #10526
several optional test dependencies are no longer used in the code base.
This commit removes them from requirements-optional.txt as several have
compatibility issues with Python 3.12 and are causing failures in the
nightly builds. Since they're no longer used we shouldn't bother
installing them anymore.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakelishman jakelishman jakelishman approved these changes

@woodsp-ibm woodsp-ibm Awaiting requested review from woodsp-ibm

@ElePT ElePT Awaiting requested review from ElePT

@kevinhartman kevinhartman Awaiting requested review from kevinhartman

Assignees

No one assigned

Labels

Changelog: Removed Add a "Removed" entry in the GitHub Release changelog.

Projects

None yet

Milestone

0.45.0

Development

Successfully merging this pull request may close these issues.

5 participants

@mtreinish @qiskit-bot @coveralls @jakelishman @kevinhartman