Replace Squeaky CI advice with custom advice#897
Merged
frankharkins merged 7 commits intomainfrom Feb 27, 2024
Merged
Conversation
Eric-Arellano
approved these changes
Feb 27, 2024
Collaborator
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
Awesome! Thanks!
Thoughts on the CI change so that Squeaky failure doesn't block uploading notebooks? That would allow this message to say to either run tox -e fix locally or to rely on CI. Totally fine to be in a follow up.
Co-authored-by: Eric Arellano <[email protected]>
Collaborator
Eric-Arellano
left a comment
Eric-Arellano
left a comment
There was a problem hiding this comment.
Thanks! Last thing to close #838 is mentioning in the README how to install tox, ideally with pipx.
Member
Author
|
Thank you too! |
frankharkins
added a commit
to frankharkins/documentation
that referenced
this pull request
Jul 22, 2024
Closes Qiskit#838. Replaces the message in CI with correct instructions for our repository. I've added a switch to remove the advice from the printed message, I think this is the neatest net logic change: frankharkins/squeaky@33e24f8. <img width="600" alt="Screenshot 2024-02-27 at 17 20 42" src="https://github.com/Qiskit/documentation/assets/36071638/dff70ada-2eca-4041-83fd-e0177bc52bca"> See #2 for the test PR. This doesn't display the message when running `tox -e lint`, but I think it's unlikely a contributor would run that command locally without first encountering it in CI. --------- Co-authored-by: Eric Arellano <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #838.
Replaces the message in CI with correct instructions for our repository. I've added a switch to remove the advice from the printed message, I think this is the neatest net logic change: frankharkins/squeaky@33e24f8.
See frankharkins#2 for the test PR.
This doesn't display the message when running
tox -e lint, but I think it's unlikely a contributor would run that command locally without first encountering it in CI.