Merged
Conversation
…how many objects where cleaned up.
qafooprofiler.c
Outdated
Contributor
There was a problem hiding this comment.
you need TSRMLS_CC in these calls
Contributor
There was a problem hiding this comment.
this is probably why Travis fails to compile the extension
Contributor
Author
There was a problem hiding this comment.
thanks! Travis runs with --enable-maintainer-zts, pain in the ass ;)
Contributor
|
The test failures are now the same than on master (i.e. 5.3.x are failing the fatal error handling). |
Contributor
Author
|
@stof Yes, somehow the SKIPIF doesn't work, i didn't investigate further what my mistake is. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better support to profile affects of garbage collection on performance.
Only tested with PHP 5.6 and hierachical profiling so far.
Todos:
The function to hook into for timing is
gc_collect_cyclesor its parentgc_zval_possible_root, but they are not pointers and cannot be exchanged.