NFC: Fixing some docstrings in the core.lp_dual transformation#3842
Merged
blnicho merged 2 commits intoPyomo:mainfrom Feb 11, 2026
Merged
NFC: Fixing some docstrings in the core.lp_dual transformation#3842blnicho merged 2 commits intoPyomo:mainfrom
blnicho merged 2 commits intoPyomo:mainfrom
Conversation
…odel the way it's implemented.
blnicho
approved these changes
Feb 11, 2026
jsiirola
approved these changes
Feb 11, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3842 +/- ##
==========================================
- Coverage 89.65% 89.61% -0.05%
==========================================
Files 902 902
Lines 105611 105611
==========================================
- Hits 94688 94645 -43
- Misses 10923 10966 +43
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3839
Summary/Motivation:
The docstrings for the public API to map between primal and dual components from the
core.lp_dualtransformation were wrong. This fixes them. All the mappings actually take the dual model as the first argument, not the primal.Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: