Fix PyROS IntersectionSet Implementation#3786
Merged
jsiirola merged 10 commits intoPyomo:mainfrom Nov 30, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3786 +/- ##
=======================================
Coverage 89.40% 89.41%
=======================================
Files 909 909
Lines 105541 105579 +38
=======================================
+ Hits 94364 94408 +44
+ Misses 11177 11171 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
jsiirola
approved these changes
Nov 19, 2025
Member
jsiirola
left a comment
jsiirola
left a comment
There was a problem hiding this comment.
Looks great. One minor documentation request, but nothing I would hold up the PR for.
blnicho
approved these changes
Nov 19, 2025
jsiirola
approved these changes
Nov 22, 2025
jsiirola
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary/Motivation:
This PR resolves issues introduced in #3341, to ensure that PyROS truly supports
IntersectionSetinstances representing intersections of uncertainty set sequences containing either of the following:CardinalitySet,FactorModelSet)DiscreteScenarioSet)These use cases are now covered in the PyROS automated tests.
Changes proposed in this PR:
IntersectionSetimplementation for cases where discrete sets and/or sets involving auxiliary parameters are to be intersectedUncertaintySetbase class attributesLegal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: