Fix KNITRO solution status mapping#3766
Merged
blnicho merged 12 commits intoPyomo:mainfrom Nov 5, 2025
Merged
Conversation
mrmundt
approved these changes
Oct 21, 2025
Contributor
|
It might be worth adding some tests to ensure that the different statuses are caught! |
Contributor
Author
|
@mrmundt that's a good idea. I will add them now then. |
eminyouskn
changed the title
Contributor
Author
|
This PR is also ready. |
blnicho
changed the title
Contributor
Author
|
@blnicho just to let you know, I added a link to the doc. |
blnicho
approved these changes
Nov 5, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3766 +/- ##
=======================================
Coverage 89.23% 89.23%
=======================================
Files 907 907
Lines 104817 104818 +1
=======================================
+ Hits 93536 93538 +2
+ Misses 11281 11280 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes
The initial implementation of KNITRO does not properly handle the mapping of solution statuses in cases where a time or iteration limit is reached, even when a feasible solution is available.
Summary/Motivation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: