LinearExpression should return tuples instead of lists#3751
Merged
mrmundt merged 2 commits intoPyomo:mainfrom Oct 17, 2025
Merged
LinearExpression should return tuples instead of lists#3751mrmundt merged 2 commits intoPyomo:mainfrom
mrmundt merged 2 commits intoPyomo:mainfrom
Conversation
mrmundt
reviewed
Oct 15, 2025
Contributor
mrmundt
left a comment
mrmundt
left a comment
There was a problem hiding this comment.
Would it be possible to add a new test based on the issue that ensures the desired behavior is actually happening as intended?
jsiirola
approved these changes
Oct 17, 2025
github-project-automation
bot
moved this from Review In Progress
to Reviewer Approved
in Pyomo 6.9.5 Release
Member
|
@mrmundt I believe that the tests are already checking that |
mrmundt
approved these changes
Oct 17, 2025
github-project-automation
bot
moved this from Reviewer Approved
to Done
in Pyomo 6.9.5 Release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3731.
Summary/Motivation:
Currently, it is possible to modify the
linear_coefsandlinear_varsof aLinearExpression, but those are not kept in sync with theargs. See #3731. Also, expressions are supposed to be immutable.Changes proposed in this PR:
LinearExpressionso thatlinear_coefsandlinear_varsreturn tuples instead of lists.Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: