Skip to content

Modify the PyROS Logging System#3732

Merged
jsiirola merged 32 commits intoPyomo:mainfrom
shermanjasonaf:pyros-alter-logging-levels
Oct 17, 2025
Merged

Modify the PyROS Logging System#3732
jsiirola merged 32 commits intoPyomo:mainfrom
shermanjasonaf:pyros-alter-logging-levels

Conversation

@shermanjasonaf
Copy link
Copy Markdown
Contributor

@shermanjasonaf shermanjasonaf commented Sep 23, 2025

Summary/Motivation:

This PR modifies the PyROS solver output logging system so that the output shown by the default logger (or any other INFO-level logger) is simplified.

Changes proposed in this PR:

  • Log the following at DEBUG, rather than INFO level: (i) full PyROS solver config, (ii) backup solver invocations, (iii) subproblem solve failures for the master feasibility and DR polishing problems, (iv) timing profile, (v) component statistics for the preprocessed model
  • Add indication of backup solver invocation to the (INFO-level) iteration log table
  • Log component statistics for the un-preprocessed model at INFO level
  • Update tests and documentation according to the new changes

TODO

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

@shermanjasonaf
Copy link
Copy Markdown
Contributor Author

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 96.63866% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.18%. Comparing base (740750d) to head (20c2e0b).

Files with missing lines Patch % Lines
pyomo/contrib/pyros/separation_problem_methods.py 88.88% 2 Missing ⚠️
pyomo/contrib/pyros/master_problem_methods.py 66.66% 1 Missing ⚠️
pyomo/contrib/pyros/pyros.py 96.15% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3732   +/-   ##
=======================================
  Coverage   89.18%   89.18%           
=======================================
  Files         896      896           
  Lines      103725   103800   +75     
=======================================
+ Hits        92508    92575   +67     
- Misses      11217    11225    +8     
Flag Coverage Δ
builders 29.09% <13.44%> (+<0.01%) ⬆️
default 85.77% <95.79%> (?)
expensive 35.70% <13.44%> (?)
linux 86.99% <96.63%> (-1.94%) ⬇️
linux_other 86.99% <96.63%> (+<0.01%) ⬆️
osx 83.14% <95.79%> (+0.01%) ⬆️
win 85.24% <96.63%> (+<0.01%) ⬆️
win_other 85.24% <96.63%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mrmundt mrmundt moved this from Todo to Review In Progress in Pyomo 6.9.5 Release Oct 7, 2025
@github-project-automation github-project-automation bot moved this from Review In Progress to Reviewer Approved in Pyomo 6.9.5 Release Oct 14, 2025
@jsiirola
Copy link
Copy Markdown
Member

@shermanjasonaf There is still a TODO on this PR (it was waiting for #3722). That PR is in - do you want to incorporate it into a subsequent PR (in which case this PR is ready to merge) or address that TODO as part of this PR (in which case we will wait)?

@shermanjasonaf
Copy link
Copy Markdown
Contributor Author

@jsiirola I have addressed the TODO here.

@jsiirola jsiirola merged commit 307330d into Pyomo:main Oct 17, 2025
70 of 71 checks passed
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in Pyomo 6.9.5 Release Oct 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects

Development

Successfully merging this pull request may close these issues.

5 participants